Skip to content

Small Lightning Driver Fixes #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dnakhooda merged 15 commits into from
Jan 13, 2026
Merged

Small Lightning Driver Fixes #358

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8f6f6b3
driver
dnakhooda Sep 28, 2025
5a41029
Merge branch 'main' of https://github.com/Northeastern-Electric-Racin…
dnakhooda Oct 12, 2025
bdc805a
Merge branch 'main' of https://github.com/Northeastern-Electric-Racin…
dnakhooda Oct 12, 2025
28828b6
fixes
dnakhooda Oct 12, 2025
e7723c1
another fix
dnakhooda Oct 12, 2025
3f24615
Merge branch 'main' into fix_lightning_sensor
dnakhooda Oct 12, 2025
892f6bb
have spi transmit do heavy work
dnakhooda Oct 19, 2025
ccc38ba
Merge branch 'fix_lightning_sensor' of https://github.com/Northeaster…
dnakhooda Oct 19, 2025
8eaf5d2
fixes
dnakhooda Oct 26, 2025
d73b5a8
small thing
dnakhooda Oct 26, 2025
45c5597
another small thing
dnakhooda Oct 26, 2025
0aa0b71
Merge branch 'main' into fix_lightning_sensor
dnakhooda Nov 23, 2025
255d73d
small fix
dnakhooda Nov 23, 2025
163c750
Merge branch 'main' into fix_lightning_sensor
dnakhooda Dec 25, 2025
95f4b3d
Merge branch 'main' into fix_lightning_sensor
dnakhooda Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions general/src/as3935.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ uint8_t as3935_read(as3935_t *as3935, uint8_t reg)

// HAL SPI wants an 8 bit array of length 2 for tx_data
HAL_StatusTypeDef status = HAL_SPI_TransmitReceive(
as3935->hspi, (uint8_t *)&tx_data, &rx_buf, 2, HAL_MAX_DELAY);
as3935->hspi, (uint8_t *)&tx_data, rx_buf, 2, HAL_MAX_DELAY);

if (status != HAL_OK) {
return 0xFF;
Expand Down Expand Up @@ -164,7 +164,7 @@ uint32_t as3935_get_energy(as3935_t *as3935)
}

// combine the three values. Only read the first 5 bits for energy_mm
energy = ((energy_mm & 0b11111) << 16) | (energy_m << 8) | energy_l;
energy = ((energy_mm & 0x1F) << 16) | (energy_m << 8) | energy_l;

return energy;
}