fix: add version and status to .PHONY targets in Makefile #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `make version` and `make status` commands were not working because they were not declared as .PHONY targets. Make was treating them as file targets and reporting "up to date" without executing the commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
versionandstatusto the.PHONYdeclaration in the Makefilemake versionandmake statuscommands which were reporting "up to date" instead of executingProblem
When running
make version, the output was:This happened because
versionandstatuswere not declared as phony targets. Make treated them as file targets and since no files namedversionorstatusexist, it considered them "up to date".Test plan
make versionoutputs version informationmake statusoutputs synchronization status