fix(vis-network): unit tests#528
Merged
fraxken merged 1 commit intoNodeSecure:masterfrom Jul 21, 2025
Merged
Conversation
7a36885 to
411fb76
Compare
fraxken
reviewed
Jul 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #528 +/- ##
============================================
- Coverage 100.00% 59.15% -40.85%
============================================
Files 15 38 +23
Lines 649 2921 +2272
Branches 0 14 +14
============================================
+ Hits 649 1728 +1079
- Misses 0 1193 +1193 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
411fb76 to
11956fc
Compare
c88b962 to
75fb2bf
Compare
75fb2bf to
caaf1b9
Compare
fraxken
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt unit tests and fixture to current implementation of dataset.
i need advice on unknown license computation, i removed their test because current algorithm does handle this case, for example :
"license": "a string licence (should be unknown)"{unknown: 1}does unknown license is buggy or not handled anymore ?