refactor: migrate new workspaces to TypeScript#526
Merged
PierreDemailly merged 1 commit intomasterfrom Jun 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the workspaces server and cache modules from JavaScript to TypeScript, adding comprehensive type annotations and updating build/test configurations.
- Introduces new tsconfig files and updates package.json scripts for TypeScript builds.
- Adds explicit TypeScript annotations across endpoints, middlewares, web socket commands, and tests.
- Enhances type safety by replacing implicit types and adding non-null assertions where needed.
Reviewed Changes
Copilot reviewed 38 out of 41 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| workspaces/server/tsconfig.json | New TypeScript configuration for the server module |
| workspaces/server/test/* | Test files updated with explicit type annotations |
| workspaces/server/src/* | Source files updated to include TypeScript types and non-null assertions |
| workspaces/cache/* | Cache module modified to use TypeScript and improved type safety |
| package.json, tsconfig.base.json, eslint.config.mjs | Build/test and linter configurations updated for TypeScript |
Comments suppressed due to low confidence (1)
workspaces/server/src/websocket/index.ts:29
- [nitpick] Consider renaming 'WebSocketServerInstanciator' to 'WebSocketServerInstantiator' to use conventional spelling.
export class WebSocketServerInstanciator {
0dce3fa to
0f7ec10
Compare
fraxken
approved these changes
Jun 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.