Localization removal and string handling, UI/UX improvements in InstanceFormView #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed instances of LocalizedStringKey to String for title properties in LabeledTextField and OutlinedBadge. - Removed String(localized:) calls for static strings in ContentView, ServerListView, ServiceListView, and various service-related views. - Updated error messages and other strings to use direct string literals instead of localization. - Deleted the Localizable.xcstrings file as localization is no longer used. - Adjusted TLSMode enum to reflect the change from "Custom Certificate" to "Trusted Certificate". - Updated NPCore methods to return direct string literals instead of localized strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily removes the use of
String(localized:)and the project's.xcstringslocalization file, switching all user-facing string initializations to plain string literals. Additionally, it moves the input mode picker in theInstanceFormViewfrom a section in the form to the navigation toolbar for a more streamlined UI.Localization removal and string handling:
String(localized:)throughout the codebase, changing user-facing strings to plain string literals in UI components such as tab titles, picker options, and dynamically constructed names and aliases. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18]Localizable.xcstringsfrom the Xcode project, including all references in the project file and build phases. [1] [2] [3] [4] [5]UI/UX improvements in InstanceFormView:
InputModefrom "Form"/"URL" to "Details"/"Command" for improved clarity.