grpc-tools: fix build for cmake 4, 1.12.4 → 1.13.0#449946
Merged
pyrox0 merged 2 commits intoNixOS:masterfrom Oct 9, 2025
Merged
grpc-tools: fix build for cmake 4, 1.12.4 → 1.13.0#449946pyrox0 merged 2 commits intoNixOS:masterfrom
pyrox0 merged 2 commits intoNixOS:masterfrom
Conversation
13 tasks
411af5e to
7a49b21
Compare
Member
|
LGTM, also note that you don't have to ping maintainers, since our auto-review bot does that for you nowadays! No harm no foul though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to 1.13.0. relnotes: https://github.com/grpc/grpc-node/releases/tag/grpc-tool%401.13.0
Fix the build for CMake 4 (tracking issue: #445447). Though it is mildly concerning that upstream is using a vendored four-year-old version of protobuf, the fix here is the same one they applied. See grpc/grpc-node#3013.
maintainer ping: @nzhang-zh (though it looks like the maintainer has been inactive on github for some years now)
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.