Conversation
There was a problem hiding this comment.
Pull request overview
Updates .gitattributes to enforce LF line endings for a broader set of text-based source/config/documentation files and clarifies SVG handling as text.
Changes:
- Add
eol=lfto many source/config/doc file patterns (C#, web assets, markdown, templates, configs). - Treat
.svgas text with LF line endings (instead of the prior commented guidance). - Remove
-difffrom*.lock/ lockfile patterns (making them diffable again).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| *.cs text eol=lf diff=csharp | ||
| *.cshtml text eol=lf diff=html | ||
| *.csx text eol=lf diff=csharp |
There was a problem hiding this comment.
The repo’s .editorconfig sets end_of_line = crlf for [*], but this change forces eol=lf for C# source files. That mismatch can cause perpetual line-ending churn (editors write CRLF, git normalizes to LF) and noisy diffs. Consider aligning one source of truth: either remove eol=lf here (let editorconfig decide), or update .editorconfig with matching end_of_line = lf overrides for these patterns (or globally).
| *.cs text eol=lf diff=csharp | |
| *.cshtml text eol=lf diff=html | |
| *.csx text eol=lf diff=csharp | |
| *.cs text diff=csharp | |
| *.cshtml text diff=html | |
| *.csx text diff=csharp |
| *.lock text | ||
| package.json text eol=lf | ||
| package-lock.json text eol=lf -diff | ||
| pnpm-lock.yaml text eol=lf -diff | ||
| .prettierrc text | ||
| *.toml text | ||
| *.yaml text | ||
| *.yml text | ||
| browserslist text | ||
| Makefile text | ||
| makefile text | ||
| package-lock.json text eol=lf | ||
| pnpm-lock.yaml text eol=lf |
There was a problem hiding this comment.
This re-enables diffs for *.lock files (previously -diff). Lockfiles are often large and auto-generated, so showing full diffs can make PRs hard to review and slow down tooling. If the goal is only line-ending normalization, keep -diff while adding the desired eol (e.g., text eol=lf -diff) for lockfile patterns.
| .env text eol=lf | ||
| .gitattributes text eol=lf | ||
| .gitconfig text eol=lf | ||
| .htaccess text eol=lf |
There was a problem hiding this comment.
These config patterns are now forced to eol=lf, but .editorconfig currently enforces end_of_line = crlf for [*]. That conflict can cause frequent line-ending reformatting (especially for .env / .htaccess which are often edited directly) and noisy diffs. Either add matching .editorconfig overrides for these files or avoid pinning eol here.
| .env text eol=lf | |
| .gitattributes text eol=lf | |
| .gitconfig text eol=lf | |
| .htaccess text eol=lf | |
| .env text | |
| .gitattributes text eol=lf | |
| .gitconfig text eol=lf | |
| .htaccess text |
No description provided.