Fix empty timestamp bug#652
Merged
bendichter merged 3 commits intodevfrom Feb 4, 2026
Merged
Conversation
Add guard for empty timestamps array in check_timestamp_of_the_first_sample_is_not_negative to prevent IndexError. The check now returns None (skips) when both starting_time is None and timestamps is empty or None.
…tive timestamp check
h-mayorquin
approved these changes
Feb 4, 2026
Contributor
Author
|
yes, I think we should. I just wanted to first fix the error. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #652 +/- ##
==========================================
+ Coverage 77.41% 80.36% +2.94%
==========================================
Files 47 47
Lines 1656 1660 +4
==========================================
+ Hits 1282 1334 +52
+ Misses 374 326 -48
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fix #582