fix(security): resolve persistent Missing rate limiting #13#113
Merged
Conversation
Replace separate auth hook registration with a single preHandler wrapper that calls req.rateLimit() before authorization so CodeQL can directly verify throttling at the flagged handler location. Co-authored-by: Cursor <cursoragent@cursor.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…hook Attach rate limiting and authorization as route preHandlers for non-public routes to make throttling explicit at route registration time and address persistent CodeQL missing-rate-limiting findings. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
authRateLimitHook+authHookregistrations with oneauthWithRateLimitpreHandlerreq.rateLimit()in the same preHandler that invokes authorizationjs/missing-rate-limitingreported atserver/src/index.jsTest plan
npm --prefix server run lintnpm --prefix server run test