feat: ssz, eth2api add bitfield accessors, synthetic graffiti by mskrzypkows · Pull Request #469 · NethermindEth/pluto

mskrzypkows · 2026-06-03T11:22:30Z

is_synthetic

Add bit_at, set_bit_at, bit_indices, contains, and or combinators to BitList and BitVector, along with a BitfieldError type for length mismatches; export BitfieldError from the ssz crate
Replace the synthetic_graffiti() runtime function with a compile-time SYNTHETIC_GRAFFITI constant using a const block
Add SignedProposalBlock::graffiti() accessor and VersionedSignedProposal::is_synthetic() using the new constant

is_synthetic - Add bit_at, set_bit_at, bit_indices, contains, and or combinators to BitList and BitVector, along with a BitfieldError type for length mismatches; export BitfieldError from the ssz crate - Replace the synthetic_graffiti() runtime function with a compile-time SYNTHETIC_GRAFFITI constant using a const block - Add SignedProposalBlock::graffiti() accessor and VersionedSignedProposal::is_synthetic() using the new constant

mskrzypkows · 2026-06-03T11:23:19Z

@claude review

claude · 2026-06-03T11:23:34Z

Claude finished @mskrzypkows's task in 3m 27s —— View job

Review: PR #469 — bitfield accessors, synthetic graffiti const, `is_synthetic`

Read the diff (ssz types, lib, versioned)
Cross-check against Charon Go source
Review correctness, style, CI
Post review feedback

Overall this is a clean, well-tested change. I verified the bitfield semantics against the Go (go-bitfield) behavior used in charon/core/tracker/inclusion.go, and the synthetic-graffiti logic against charon/app/eth2wrap/synthproposer.go. One blocking CI item and a few minor notes below.

🔴 Blocking — CI `Linter check` (rustfmt) is failing

The only failure relevant to this PR is cargo +nightly fmt --all -- --check. The doc comment above SYNTHETIC_GRAFFITI exceeds the line width and rustfmt wants it wrapped (crates/eth2api/src/versioned.rs:12):

/// 32-byte graffiti used to mark synthetic blocks, left-aligned with zero
/// padding.
pub const SYNTHETIC_GRAFFITI: phase0::Root = {

(The other PR Naming Convention failure is a duplicate/transient — two sibling runs passed. Build and test is still in progress.)

Fix this →

✅ Correctness (verified against Charon)

BitList::contains — other & self == other per byte matches go-bitfield's Bitlist.Contains (b[i]^(b[i]|c[i]) != 0), and the DifferentLength guard matches the Go length check. ✔
BitList::or — byte-wise OR with length guard matches Bitlist.Or. ✔
bit_indices / bit_at / set_bit_at — out-of-range reads as false, out-of-range set is a no-op; indices ascending. Matches BitIndices usage in inclusion.go / validatorapi.go. ✔
SYNTHETIC_GRAFFITI const — phase0::Root is [u8; 32]; the marker is 29 bytes so the while copy can't overflow (and would fail at compile time if it ever did). Equivalent to Go's GetSyntheticGraffiti() (copy(buf[:], syntheticBlockGraffiti)). ✔
graffiti() / is_synthetic() — covers all 12 enum variants (incl. the Deneb/Electra/Fulu signed_block nesting) and correctly unifies Go's separate IsSyntheticProposal + IsSyntheticBlindedBlock, since SignedProposalBlock already carries both blinded and full variants. ✔

The trailing-bit invariant that contains/or rely on (bits past len are zero) holds for every constructor (from_ssz_bytes masks the remainder, with_bits only sets in-range bits, set_bit_at guards i >= len), so the byte-level ops are safe.

🟡 Minor / non-blocking

PR description vs. diff. The description says it replaces a synthetic_graffiti() runtime function, but the diff is purely additive (+221/-1) — no such function existed or was removed. Worth correcting the description to avoid confusion for reviewers/changelog.
VersionedSignedBlindedProposal has no is_synthetic(). Go exposes IsSyntheticBlindedBlock on the blinded wrapper too. Here it's only on VersionedSignedProposal. That's fine if all synthetic checks go through VersionedSignedProposal (which can hold blinded variants), but if the blinded wrapper is ever checked directly, it'll need its own accessor. Flagging for awareness — not required for this PR.
BitVector is intentionally asymmetric with BitList (no contains/or). This matches Go usage (only BitIndices is used on committee bit-vectors), so leaving them off is reasonable — just calling it out.
Test coverage is good — bit_at/set_bit_at/bit_indices, the SSZ round-trip alignment test, both contains/or length-mismatch paths, and the graffiti layout/zero-padding test. Nice.
· branch bitfield_ops

iamquang95 · 2026-06-04T04:41:10Z

+    /// Unifies Go's separate blinded/full checks: the payload enum already
+    /// carries both blinded and full variants, so a single graffiti comparison
+    /// covers every case.
+    pub fn is_synthetic(&self) -> bool {


Need to check version first:
https://github.com/ObolNetwork/charon/blob/v1.7.1/app/eth2wrap/synthproposer.go#L262

iamquang95 · 2026-06-04T04:43:00Z

+    /// Returns the bit at index `i`, or `false` if `i` is out of range.
+    pub fn bit_at(&self, i: usize) -> bool {
+        if i >= self.len {
+            return false;


is this better return Result / Option for this function?

iamquang95 · 2026-06-04T04:44:54Z

+    /// Sets the bit at index `i` to `value`; out-of-range indices are ignored.
+    pub fn set_bit_at(&mut self, i: usize, value: bool) {
+        if i >= self.len {
+            return;


iamquang95

other part lgtm

mskrzypkows added 2 commits June 3, 2026 13:21

Merge branch 'main' of github.com:NethermindEth/pluto into bitfield_ops

a60cc5f

mskrzypkows changed the title ~~feat(ssz,eth2api): add bitfield accessors, synthetic graffiti const, and~~ feat: ssz, eth2api add bitfield accessors, synthetic graffiti const, and Jun 3, 2026

mskrzypkows changed the title ~~feat: ssz, eth2api add bitfield accessors, synthetic graffiti const, and~~ feat: ssz, eth2api add bitfield accessors, synthetic graffiti Jun 3, 2026

lint

5de9cbb

mskrzypkows requested review from emlautarom1 and iamquang95 June 3, 2026 11:29

iamquang95 reviewed Jun 4, 2026

View reviewed changes

iamquang95 approved these changes Jun 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ssz, eth2api add bitfield accessors, synthetic graffiti#469

feat: ssz, eth2api add bitfield accessors, synthetic graffiti#469
mskrzypkows wants to merge 3 commits into
mainfrom
bitfield_ops

mskrzypkows commented Jun 3, 2026

Uh oh!

mskrzypkows commented Jun 3, 2026

Uh oh!

claude Bot commented Jun 3, 2026 •

edited

Loading

Uh oh!

iamquang95 Jun 4, 2026

Uh oh!

iamquang95 Jun 4, 2026

Uh oh!

iamquang95 Jun 4, 2026

Uh oh!

iamquang95 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mskrzypkows commented Jun 3, 2026

Uh oh!

mskrzypkows commented Jun 3, 2026

Uh oh!

claude Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review: PR #469 — bitfield accessors, synthetic graffiti const, is_synthetic

🔴 Blocking — CI Linter check (rustfmt) is failing

✅ Correctness (verified against Charon)

🟡 Minor / non-blocking

Uh oh!

iamquang95 Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

iamquang95 Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

iamquang95 Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

iamquang95 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

claude Bot commented Jun 3, 2026 •

edited

Loading

Review: PR #469 — bitfield accessors, synthetic graffiti const, `is_synthetic`

🔴 Blocking — CI `Linter check` (rustfmt) is failing