refactor: improve the deadline module#423
Open
therustmonk wants to merge 15 commits into
Open
Conversation
therustmonk
changed the title
therustmonk
force-pushed
the
kd-may18-errors
branch
from
15a9863 to
02b53d2
Compare
mskrzypkows
reviewed
May 20, 2026
|
|
||
| /// Wall-clock start of the given slot: `genesis_time + slot * | ||
| /// slot_duration`. | ||
| fn slot_start(&self, slot: SlotNumber) -> Result<DateTime<Utc>> { |
Contributor
There was a problem hiding this comment.
would be good to have a unit test for it
mskrzypkows
reviewed
May 20, 2026
|
|
||
| /// Network-delay margin added to every deadline: `slot_duration / | ||
| /// MARGIN_FACTOR`. | ||
| fn margin(&self) -> Result<Millis> { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.