feat: createdkg rebases on create cluster branch#315
Closed
mskrzypkows wants to merge 11 commits intobohdan/cmd-create-clusterfrom
Closed
feat: createdkg rebases on create cluster branch#315mskrzypkows wants to merge 11 commits intobohdan/cmd-create-clusterfrom
mskrzypkows wants to merge 11 commits intobohdan/cmd-create-clusterfrom
Conversation
* refactor(p2p): add shared protobuf read/write helpers * fix(relay): add initial delay
* feat: add deadline.rs * feat: deadline tests * fix: remove comments * refactor: remove old app/deadline * fix: review comments * fix: linter * fix: update Cargo.lock * fix: busy loop * fix: claude review * fix: add far-future duration * fix: review comments
* Command test beacon ported from Charon. Added url parsing and basic auth for request_rrt function. * clippy and some functions extracted * fmt * skip result extracted * pass string by reference to tests * cli test commands constants module * Added beacon.rs unit tests, moved common test functions to helpers module. * fmt * reduced usage of clippy::arithmetic_side_effects to concrete lines, added NonZero for SLOT_TIME_SECS and SLOTS_IN_EPOCH * slot update comment * reveiw corrections * Corrected passing cancelation token to the beacon test * Docker compose file for the pluto alpha test beacon * fixed tests * Made test cases const array * unneeded child_token * JoinSet for collecting tests result instead of channels vector * unneeded clone * Comment regarding status code check * review corrections * review cont. * missing log info * fixed canceling timeout task * tokio::fs::write instead of std * Update crates/cli/src/commands/test/beacon.rs Co-authored-by: Lautaro Emanuel <31224949+emlautarom1@users.noreply.github.com> * Apply suggestion from @emlautarom1 Co-authored-by: Lautaro Emanuel <31224949+emlautarom1@users.noreply.github.com> * review, fixed intervals tick for tests * fmt * changed &str to impl AsRef<str> * removed parse_endpoint_url, percent_decode, apply_basic_auth * shadowing variables instead of renaming * impl AsRef instead of `&` * join set * cancelation fixes, more Join Sets usage * improved returning failed test * review cont. * unneeded files * missing join set * removed redundant sleeping in simulation test * percent-encoding not needed * child_token -> clone in cli/src/main.rs --------- Co-authored-by: Lautaro Emanuel <31224949+emlautarom1@users.noreply.github.com>
…pluto into createdkg_rebase_on_create_cluster
mskrzypkows
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.