Skip to content

feat(rpcv10): response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380

Merged
rodrodros merged 27 commits intomainfrom
maksym/rpcv10-response-flags
Feb 17, 2026
Merged

feat(rpcv10): response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380
rodrodros merged 27 commits intomainfrom
maksym/rpcv10-response-flags

Conversation

@MaksymMalicki
Copy link
Copy Markdown
Contributor

@MaksymMalicki MaksymMalicki commented Jan 19, 2026

This PR introduces support for new optional fields for transactions:

  • proof_facts for invoke v3 transactions
  • proof and proof_facts for broadcasted invoke v3 transactions, which are passed to the gateway write API

The invoke v3 transactions will contain proof_facts optional field, when the INCLUDE_PROOF_FACTS flag is included in the response_flags new parameter in starknet_getBlockWithTxs, starknet_getBlockWithReceipts, starknet_getTransactionByHash, starknet_getTransactionByBlockIdAndIndex. If the flag is not present, the transactions are processed in the same way as in previous versions of the RPC.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2026

Codecov Report

❌ Patch coverage is 67.37160% with 108 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.39%. Comparing base (5ce32d2) to head (66575f7).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rpc/v10/transaction.go 59.36% 73 Missing and 16 partials ⚠️
rpc/v10/estimate_fee.go 0.00% 13 Missing ⚠️
rpc/v9/transaction.go 88.88% 4 Missing ⚠️
rpc/v10/response_flags.go 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
- Coverage   75.44%   75.39%   -0.05%     
==========================================
  Files         378      379       +1     
  Lines       35284    35555     +271     
==========================================
+ Hits        26619    26807     +188     
- Misses       6806     6869      +63     
- Partials     1859     1879      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Copy link
Copy Markdown
Contributor

@EgeCaner EgeCaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round of review

Comment thread rpc/v10/response_flags.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/block_test.go Outdated
Comment thread rpc/v10/transaction_test.go
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch 2 times, most recently from c0b55b8 to 9b8cc56 Compare February 6, 2026 10:38
Comment thread rpc/v10/block_test.go
Comment thread rpc/v10/block_test.go
Comment thread rpc/v10/block_test.go Outdated
Comment thread rpc/v10/block_test.go Outdated
Comment thread rpc/v10/response_flags.go Outdated
Comment thread rpc/v10/transaction_test.go Outdated
Comment thread rpc/v10/transaction_test.go Outdated
Comment thread rpc/v10/transaction_test.go Outdated
Comment thread rpc/v10/transaction_test.go Outdated
Comment thread rpc/v10/transaction_test.go Outdated
Copy link
Copy Markdown
Contributor

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Overall, good job!

I've found two bugs while reviewing.
This is only a partial review. I still need to finish reviewing the test files, but I thought it would be good to submit this review right now, so that you can fix them while I finish.

These bugs show us that we need to improve the new tests, since they passed without catching them

Comment thread adapters/p2p2core/transaction.go
Comment thread rpc/v10/transaction.go Outdated
Comment thread rpc/v10/transaction.go Outdated
Copy link
Copy Markdown
Contributor

@thiagodeev thiagodeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finished my review. LGTM.
I'm ready to approve after you apply the fix for the two bugs I mentioned in the previous review

Comment thread rpc/v10/transaction_test.go Outdated
@MaksymMalicki MaksymMalicki force-pushed the maksym/rpcv10-response-flags branch from 58bad55 to 66575f7 Compare February 17, 2026 15:00
@rodrodros rodrodros merged commit 5d74f82 into main Feb 17, 2026
23 of 26 checks passed
@rodrodros rodrodros deleted the maksym/rpcv10-response-flags branch February 17, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants