feat(rpcv10): response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380
feat(rpcv10): response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380
response_flags for the rpcv10; proof_facts, proof for invoke v3 txs#3380Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3380 +/- ##
==========================================
- Coverage 75.44% 75.39% -0.05%
==========================================
Files 378 379 +1
Lines 35284 35555 +271
==========================================
+ Hits 26619 26807 +188
- Misses 6806 6869 +63
- Partials 1859 1879 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c0b55b8 to
9b8cc56
Compare
thiagodeev
left a comment
There was a problem hiding this comment.
Hey. Overall, good job!
I've found two bugs while reviewing.
This is only a partial review. I still need to finish reviewing the test files, but I thought it would be good to submit this review right now, so that you can fix them while I finish.
These bugs show us that we need to improve the new tests, since they passed without catching them
thiagodeev
left a comment
There was a problem hiding this comment.
I've finished my review. LGTM.
I'm ready to approve after you apply the fix for the two bugs I mentioned in the previous review
58bad55 to
66575f7
Compare
This PR introduces support for new optional fields for transactions:
proof_factsfor invoke v3 transactionsproofandproof_factsfor broadcasted invoke v3 transactions, which are passed to the gateway write APIThe invoke v3 transactions will contain
proof_factsoptional field, when theINCLUDE_PROOF_FACTSflag is included in theresponse_flagsnew parameter instarknet_getBlockWithTxs,starknet_getBlockWithReceipts,starknet_getTransactionByHash,starknet_getTransactionByBlockIdAndIndex. If the flag is not present, the transactions are processed in the same way as in previous versions of the RPC.