fix(netifyd): improvements#1700
Merged
Merged
Conversation
Tbaile
force-pushed
the
netifyd-improvements
branch
from
6b5ddcd to
827321b
Compare
Tbaile
force-pushed
the
netifyd-improvements
branch
3 times, most recently
from
6780c5a to
0e05242
Compare
Tbaile
force-pushed
the
netifyd-improvements
branch
2 times, most recently
from
36c37ae to
368b4d3
Compare
gsanchietti
reviewed
Jun 17, 2026
gsanchietti
approved these changes
Jun 17, 2026
gsanchietti
left a comment
gsanchietti
left a comment
Member
There was a problem hiding this comment.
I did not try it, but take a look if it's better to write the messages to stderr.
Still, the logic is ok for me, feel free to merge as is.
| if chain in valid_chains: | ||
| firewall_chains.append(chain) | ||
| else: | ||
| print(f"Warning: invalid firewall_traffic value '{chain}', ignoring. Valid values: {sorted(valid_chains)}") |
Member
There was a problem hiding this comment.
Maybe it's better to print to stderr?
Suggested change
| print(f"Warning: invalid firewall_traffic value '{chain}', ignoring. Valid values: {sorted(valid_chains)}") | |
| print(f"Warning: invalid firewall_traffic value '{chain}', ignoring. Valid values: {sorted(valid_chains)}", file=sys.stderr) |
| else: | ||
| print(f"Warning: invalid firewall_traffic value '{chain}', ignoring. Valid values: {sorted(valid_chains)}") | ||
| if not firewall_chains: | ||
| print("Warning: no valid firewall_traffic chains configured, defaulting to all chains.") |
Member
There was a problem hiding this comment.
Maybe it's better to print to stderr?
Suggested change
| print("Warning: no valid firewall_traffic chains configured, defaulting to all chains.") | |
| print("Warning: no valid firewall_traffic chains configured, defaulting to all chains.", file=sys.stderr) |
| # SPDX-License-Identifier: GPL-2.0-only | ||
| # | ||
|
|
||
| import os |
Member
There was a problem hiding this comment.
Suggested change
| import os | |
| import sys |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily total trafficfix(monitoring): using correct label for netifyd analyzed traffic nethsecurity-ui#782