Open
Conversation
Transform the command bar from a simple phone dialer into a full contact search bar. Users can now type a name to search the phonebook and local operators, navigate results with arrow keys, and call with Enter. - Search phonebook via API with 250ms debounce and stale-request cancellation - Local operator matching (name + extension) displayed first, deduped against phonebook results - Operator results show avatar and presence indicator - Keyboard navigation: ArrowUp/Down to select, Enter to call, Escape to close - Dynamic window resize via new COMMAND_BAR_RESIZE IPC event with full setBounds rect (avoids DPI issues on Windows) - Cache operators/avatars with 30s TTL to avoid redundant API calls - Memoize expensive computations (operator filtering, result merging) - Fix IPC listener leak: proper cleanup on effect re-run - Non-mutating mapContact for safer data handling
35e93d9 to
9d6c524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMAND_BAR_RESIZEIPC event, using fullsetBoundsrect to avoid DPI drift on Windows multi-monitor setupsChanges
src/renderer/src/pages/CommandBarPage.tsxNethVoiceAPI.Phonebook.search()with 250ms debounce and stale-request cancellationSearchNumberBox.getFoundedOperators()logicAvatarcomponent with presence dot for operator resultsuseMemofor operator matching and result merging (avoids recomputation on hover/selection changes)removeAllListeners) on effect re-runmapContact(returns new object via spread)src/main/classes/controllers/CommandBarController.tsresize()method with full{x, y, width, height}rect insetBoundsshow()uses singlesetBoundscall with full recthide()callswindow.hide()directly (no degeneratesetBounds(0,0))src/main/lib/ipcEvents.tsCOMMAND_BAR_RESIZEIPC eventsrc/shared/constants.tsCOMMAND_BAR_RESIZEentry inIPC_EVENTSenumTranslations