Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@whitdog47
Copy link
Contributor

@whitdog47 whitdog47 commented Aug 8, 2025

This PR enhances the TagPicker component's validation flexibility by introducing configurable validation for required and exclusive tags. The changes decouple tag validation logic from the component's hardcoded behavior, allowing different contexts to apply appropriate validation rules.

  • Added validateRequiredTags and validateExclusiveTags props to control validation behavior
  • Required tag validation is disabled by default and enabled only for incident/case reports and detail forms
  • Exclusive tag validation remains enabled by default but is disabled for filter and search modals

@whitdog47 whitdog47 requested a review from Copilot August 8, 2025 17:56
@whitdog47 whitdog47 self-assigned this Aug 8, 2025
@whitdog47 whitdog47 added the bug Something isn't working label Aug 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the TagPicker component's validation flexibility by introducing configurable validation for required and exclusive tags. The changes decouple tag validation logic from the component's hardcoded behavior, allowing different contexts to apply appropriate validation rules.

  • Added validateRequiredTags and validateExclusiveTags props to control validation behavior
  • Required tag validation is disabled by default and enabled only for incident/case reports and detail forms
  • Exclusive tag validation remains enabled by default but is disabled for filter and search modals

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/dispatch/static/dispatch/src/tag/TagPicker.vue Core component changes adding validation props and conditional logic
src/dispatch/static/dispatch/src/signal/NewEditDialog.vue Enables required tag validation for signal editing
src/dispatch/static/dispatch/src/search/SearchFilterCreateDialog.vue Disables exclusive tag validation for search filters
src/dispatch/static/dispatch/src/incident_role/PolicyRoleBuilder.vue Disables exclusive tag validation for policy role configuration
src/dispatch/static/dispatch/src/incident/TableFilterDialog.vue Disables exclusive tag validation for incident table filters
src/dispatch/static/dispatch/src/incident/TableExportDialog.vue Disables exclusive tag validation for incident export
src/dispatch/static/dispatch/src/incident/ReportSubmissionForm.vue Enables required tag validation for incident reporting
src/dispatch/static/dispatch/src/incident/ReportSubmissionCard.vue Enables required tag validation for incident submission
src/dispatch/static/dispatch/src/incident/DetailsTab.vue Enables required tag validation for incident details
src/dispatch/static/dispatch/src/data/source/TableFilterDialog.vue Disables exclusive tag validation for source table filters
src/dispatch/static/dispatch/src/data/source/EditBasicInfoTab.vue Enables required tag validation for source editing
src/dispatch/static/dispatch/src/data/query/TableFilterDialog.vue Disables exclusive tag validation for query table filters
src/dispatch/static/dispatch/src/data/query/EditBasicInfoTab.vue Enables required tag validation for query editing
src/dispatch/static/dispatch/src/dashboard/incident/IncidentDialogFilter.vue Disables exclusive tag validation for dashboard incident filters
src/dispatch/static/dispatch/src/dashboard/case/CaseDialogFilter.vue Disables exclusive tag validation for dashboard case filters
src/dispatch/static/dispatch/src/case/TableFilterDialog.vue Disables exclusive tag validation for case table filters
src/dispatch/static/dispatch/src/case/TableExportDialog.vue Disables exclusive tag validation for case export
src/dispatch/static/dispatch/src/case/DetailsTab.vue Enables required tag validation for case details

@whitdog47 whitdog47 requested a review from aaronherman August 8, 2025 18:00
@whitdog47 whitdog47 merged commit 4877caa into main Aug 12, 2025
14 checks passed
@whitdog47 whitdog47 deleted the fix/tag-picker-option-for-validation branch August 12, 2025 17:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants