This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(search_filter): adds refresh to search filter when not showing #6169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a refresh button to the search filter expression edit dialog to allow users to re-fetch search filter data when edits need to be reverted or when the expression doesn't load initially.
- Creates a new API endpoint
/detail/{search_filter_id}to retrieve a specific search filter by ID - Adds a
getaction to the search store for fetching individual search filters - Implements a refresh button in the EditDialog component that calls the new get action
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/dispatch/search_filter/views.py | Adds new API endpoint for retrieving search filter by ID with proper error handling |
| src/dispatch/static/dispatch/src/search/api.js | Updates API client to use new detail endpoint URL |
| src/dispatch/static/dispatch/src/search/store.js | Adds new get action for fetching individual search filters |
| src/dispatch/static/dispatch/src/search/EditDialog.vue | Implements refresh button UI and reloadExpression method |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: David Whittaker <84562015+whitdog47@users.noreply.github.com>
nathanmyee
reviewed
Aug 12, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a refresh button to the search filter expression edit dialog to allow users to re-fetch the search filter expression when edits need to be reverted or when the expression doesn't load initially.
getaction to the search store for fetching individual search filters