This repository was archived by the owner on Sep 3, 2025. It is now read-only.
feat(playwright): optimizes playwright tests #6153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
requested review from
aaronherman,
Copilot,
whitdog47 and
wssheldon
and removed request for
Copilot and
whitdog47
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes Playwright test performance and reliability by reducing unnecessary waits, configuring environment-specific settings, and implementing test sharding for CI environments.
Key changes include:
- Removes a 2-minute hardcoded delay in user registration tests
- Configures different timeouts and browser coverage for CI vs local development
- Implements test sharding to parallelize CI test execution across 4 shards
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/static/e2e/pages/auth-page.ts | Removes unnecessary 2-minute timeout from user registration flow |
| playwright.config.ts | Adds environment-specific configurations for timeouts, tracing, and browser coverage |
| .github/workflows/playwright.yml | Implements test sharding and fixes empty STATIC_DIR environment variable |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Marc Vilanova <39573146+mvilanova@users.noreply.github.com>
aaronherman
approved these changes
Jul 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.