Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@aaronherman
Copy link
Contributor

This pull request introduces updates to the visibility logic for cases and incidents, ensuring that the "Join" button is conditionally displayed based on the visibility status.

@aaronherman aaronherman requested a review from Copilot July 24, 2025 20:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the visibility logic for cases and incidents by hiding the "Join" button when items have restricted visibility, preventing users from joining restricted cases and incidents they shouldn't access.

  • Updated the join button visibility condition in both IncidentStatus and CaseStatus components to check for restricted visibility
  • Added visibility prop to both status components with a default value of "Open"
  • Passed the visibility property from table components to their respective status components

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
src/dispatch/static/dispatch/src/incident/status/IncidentStatus.vue Adds visibility prop and updates join button condition to exclude restricted items
src/dispatch/static/dispatch/src/incident/Table.vue Passes visibility property to IncidentStatus component
src/dispatch/static/dispatch/src/case/Table.vue Passes visibility property to CaseStatus component
src/dispatch/static/dispatch/src/case/CaseStatus.vue Adds visibility prop and updates join button condition to exclude restricted items

@aaronherman aaronherman added the enhancement New feature or request label Jul 24, 2025
Signed-off-by: Aaron Herman <12768929+aaronherman@users.noreply.github.com>
@aaronherman aaronherman merged commit 8c05f10 into main Jul 24, 2025
9 checks passed
@aaronherman aaronherman deleted the fix/hide-join-on-restricted-cases branch July 24, 2025 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants