This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix EditSheet for cases and incidents to allow linking to Timeline #6147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request improves tab navigation for cases and incidents by transitioning from numeric tab indexing to string-based tab values, and adds a dedicated route for case timeline access. The changes enable direct linking to specific tabs (particularly the timeline) and make the codebase more maintainable.
- Replaces numeric tab indices with string values for better maintainability and direct navigation
- Adds a new route for case timeline access with proper metadata configuration
- Implements route-based tab navigation logic for cases similar to existing incident functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/router/config.js | Adds new route for case timeline with showTimeline metadata |
| src/incident/EditSheet.vue | Updates tab navigation to use string values instead of numeric indices |
| src/case/EditSheet.vue | Replaces key attributes with value attributes for tabs and adds route watcher for timeline navigation |
mvilanova
approved these changes
Jul 24, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the handling of tabs and navigation in the
EditSheet.vuecomponents for cases and incidents, as well as adding a new route for case timelines. The key changes include replacing thekeyattribute withvaluefor tabs and window items, updating tab navigation logic, and introducing a dedicated route for case timelines.