This repository was archived by the owner on Sep 3, 2025. It is now read-only.
Do not set password to None before user creation call #6007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvilanova
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the handling of the password field during user creation by ensuring that a password is never set to None. The key change removes the conditional check for None and always converts the provided password to bytes, ensuring consistency in the user creation process.
Comments suppressed due to low confidence (1)
src/dispatch/auth/service.py:151
- Removing the condition that checks for None may lead to a TypeError if user_in.password is None (e.g., for SSO users). Consider adding an assertion or exception to handle cases where user_in.password is None before conversion.
password = bytes(user_in.password, "utf-8")
whitdog47
approved these changes
May 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.