Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Conversation

@mvilanova
Copy link
Contributor

No description provided.

@mvilanova mvilanova requested a review from Copilot May 21, 2025 16:53
@mvilanova mvilanova self-assigned this May 21, 2025
@mvilanova mvilanova added the bug Something isn't working label May 21, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Pydantic user models to prevent null values for the password field and avoid database NotNullViolation errors on user creation.

  • Changed UserLogin.password from optional (str | None = None) to a required str.
  • Adjusted UserRegister.password to default to an empty string instead of None.
Comments suppressed due to low confidence (1)

src/dispatch/auth/models.py:168

  • Add tests for missing or empty password on login and registration to verify that the custom validator raises the expected error and prevents null or empty values.
    password: str

@mvilanova mvilanova merged commit 82e9444 into main May 21, 2025
9 checks passed
@mvilanova mvilanova deleted the mvilanova-patch-1 branch May 21, 2025 16:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants