This repository was archived by the owner on Sep 3, 2025. It is now read-only.
fix(UI): ensure project consistency in tag validation and fetching #6004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the `TagPicker.vue` component to use a `ref` for the current project, ensuring that tag validation and fetching operations are consistent with the selected project. This change prevents unnecessary data fetching and validation when the project remains unchanged.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the TagPicker.vue component to use a ref (currentProject) for ensuring consistency in tag validation and fetching operations according to the selected project.
- Introduced a new ref (currentProject) to track the current project.
- Updated the watch callback, fetchData, and validateTags functions to use currentProject instead of props.project.
Comments suppressed due to low confidence (2)
src/dispatch/static/dispatch/src/tag/TagPicker.vue:292
- The tag property was changed from 'tag.project' to 'tag.currentProject' here. Please verify that the tag objects now include 'currentProject' rather than 'project' to avoid breaking tag validation.
all_tags_in_project = value.every((tag) => tag.currentProject?.id == project_id)
src/dispatch/static/dispatch/src/tag/TagPicker.vue:300
- The property reference was updated from 'tag.project?.name' to 'tag.currentProject?.name'. Confirm that the tag data structure is updated accordingly to support this change.
all_tags_in_project = value.every((tag) => tag.currentProject?.name == project_name)
I updated the property access from `currentProject` to `project` in the `validateTags` function to ensure proper validation of tags against the current project.
wssheldon
approved these changes
May 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the
TagPicker.vuecomponent to use areffor the current project, ensuring that tag validation and fetching operations are consistent with the selected project. Fixes an issue where the project set via the url wasn't being propagated correctly.