Sourcemod default mappicker works

[blaberry]

In OGNT, we have a custom map picker. The reason for this is that the regular "end of match is coming" event that sourcemods default mappicker hooks into doesn't exist. We should make it so the SM default map picker works.

[blaberry]

Let's abandon this due to having comp natively.

[DESTROYGIRL]

Assuming its for plugins it might still be useful, but if not they can still hook in to the output on neo_game_config probably

[Rainyan]

Assuming its for plugins it might still be useful, but if not they can still hook in to the output on neo_game_config probably

I agree that having useful events for different, well, events, would be useful for plugins/server modding. It might be a good top-level issue with all the desired events, once we've decided what those would be. I imagine things like assists, ghost pickup, ghost drop, ghost cap, ghost-assisted-frag maybe? Round start, round end with details of round outcome. Etc.

Especially keeping track of ghost pickup status is really common in plugins (there's a whole plugin dedicated just for it), so having native events for that would be nice. Also lacking a native "round concluded now" event sucks, because it's quite difficult to check for. Again various plugins exist specifically for this to make it less painful for other plugins to track.

Another good thing to have would be compatibility with OG NT events for better plugin compatibility. We currently have mock-ups of game_round_start and game_round_end ifdef'd away in the code base; those would probably be quite trivial to get working.
For player_death event, we're extending the OG NT values which is fine, but it seems ours is missing the original's icon field, which we could add for compat.

[Agiel]

As mentioned in discord, the mapchooser plugin also relies on this to show the vote menu when a team is close to winning. For OGNT we use a modified mapchooser, but I think it's better to make NT;RE work with the stock plugin. There's the option of submitting a PR to SourceMod, but I'd rather we conform to the "standard".

[Rainyan]

Since this issue is kind of in limbo, it might be constructive to split it into:

• An issue for the mapchooser SourceMod standard compatibility as mentioned above ("plugin parity" kind of?)
• An issue for any other events we might want ("extended development")

Hopefully with the appropriate information/issue templates filled out.

[blaberry]

Let's keep this issue for "native SM mapchooser works" and I'll make a separate issue for "Events we want".