fix(types): NodeNext-compatible import in fxp.d.ts (TS2834)#809
Open
tomquist wants to merge 1 commit intoNaturalIntelligence:masterfrom
Open
fix(types): NodeNext-compatible import in fxp.d.ts (TS2834)#809tomquist wants to merge 1 commit intoNaturalIntelligence:masterfrom
tomquist wants to merge 1 commit intoNaturalIntelligence:masterfrom
Conversation
Relative imports in declaration files must use explicit .js extensions when consumers use moduleResolution node16/nodenext with skipLibCheck false. Fixes NaturalIntelligence#808
marklai1998
approved these changes
Mar 23, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #808.
Under
moduleResolution"node16"/"nodenext", TypeScript requires explicit file extensions on relative imports in.d.tsfiles. The ESM types entry (exports["."].import.types→./src/fxp.d.ts) imported'./pem', which triggers TS2834 for consumers withskipLibCheck: false.This PR is similar to #810 but without the regression test.
Change
src/fxp.d.tsto'./pem.js'(TypeScript resolves this topem.d.ts, matching the emittedfxp.jspattern).Verification
Local
tscwithmodule/moduleResolutionNodeNext,skipLibCheck: false, andfilesincludingsrc/fxp.d.ts+src/pem.d.tscompletes with no errors.