Skip to content

Add missing exports to fxp commonjs types#782

Merged
amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom
jeremymeng:patch-1
Feb 8, 2026
Merged

Add missing exports to fxp commonjs types#782
amitguptagwl merged 1 commit intoNaturalIntelligence:masterfrom
jeremymeng:patch-1

Conversation

@jeremymeng
Copy link
Contributor

@jeremymeng jeremymeng commented Feb 6, 2026

Similar to PR #744, the commonjs version of typing file should export public types. otherwise, we are getting this error when building for commonjs:

xml-helpers.ts(8,15): error TS2305: Module '"fast-xml-parser"' has no exported member 'XmlBuilderOptions'.

Purpose / Goal

related to issue #736

Type

Please mention the type of PR

  • Bug Fix
  • Refactoring / Technology upgrade
  • New Feature

Similar to PR NaturalIntelligence#744, the commonjs version of types need to export types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants