fix(ios): Fix check for dynamic lib#6032
Open
PeterStaev wants to merge 1 commit intoNativeScript:mainfrom
Open
fix(ios): Fix check for dynamic lib#6032PeterStaev wants to merge 1 commit intoNativeScript:mainfrom
PeterStaev wants to merge 1 commit intoNativeScript:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There seems to be a problem with the check whether or not a library is dynamic so it can be set to embed. This causes problems with some 3rd party plugins (see triniwiz/nativescript-plugins#223) and makes the apps crash on startup (both simulator and device).
For some reason the current logic isn't looking at the
BinaryPaththat there is in the Info.plist for the framework, but is trying to "guess" the path to the binary from other parts.For example for the CouchBase plugin the path that the current logic generates is:
But the correct path is:
What is the new behavior?
The binary path is calculated first based on the
BinaryPathfrom the Info.plist and if that is not present the old logic is used.Fixes/Implements/Closes #[Issue Number].