Remove automatic is_comped detection from invoice handler#332
Merged
Remove automatic is_comped detection from invoice handler#332
Conversation
Stop auto-setting is_comped based on invoice total being zero. The comped status should only be set intentionally via admin tools. Renamed method to updateSubscriptionPricePaid to reflect its purpose. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Check subscription active() status instead of just existence, so canceled/ended subscriptions correctly show "No active subscription". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_compedflag detection inHandleInvoicePaidJobthat was setting subscriptions as comped when the invoice total was zerosubscriptions:mark-compedcommand, Filament admin panel,GrantProductcommand)updateSubscriptionCompedStatus()toupdateSubscriptionPricePaid()to reflect its actual purposeis_compedis not auto-set on zero-total invoicesTest plan
HandleInvoicePaidJobTesttests passis_compedto trueprice_paidis still correctly recorded from invoice totals🤖 Generated with Claude Code