-
Notifications
You must be signed in to change notification settings - Fork 27
Iron: Example with independently sized mine and iron/steel plant #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jmartin4nrel
wants to merge
48
commits into
NatLabRockies:develop
Choose a base branch
from
jmartin4nrel:iron_mine_plant_diff_sizes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Iron: Example with independently sized mine and iron/steel plant #433
jmartin4nrel
wants to merge
48
commits into
NatLabRockies:develop
from
jmartin4nrel:iron_mine_plant_diff_sizes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on_mine_plant_diff_sizes
johnjasa
reviewed
Jan 5, 2026
Comment on lines
161
to
167
| total_priority = np.sum(commodity_to_priority) | ||
| total_other = np.sum(commodity_to_other) | ||
| # Need to do this in case _out is different units than _producced | ||
| frac_priority = total_priority / (total_priority + total_other) | ||
| total_produced = inputs[f"total_{self.config.commodity}_produced"] | ||
| total_priority = total_produced * frac_priority | ||
| total_other = total_produced * (1 - frac_priority) |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be able to refactor this to not require total_iron_ore_produced and instead get the sum in the splitter directly. This simplifies the tech interconnections. Suggested by @dakotaramos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example with independently sized mine and iron/steel plant
This PR changes the iron example (#21) so that the
iron_minecan be realistically large and produce a largeiron_ore_outstream that is not entirely consumed by the downstreamiron_plant. This allows theiron_ore_priceto be calculated separately in its own financial subgroup, then passed to theiron_plantvia a feedstock.Early draft PR, tests and docs needed.
Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.mdhas been updated to describe the changes made in this PRSection 3: Related Issues
Section 4: Impacted Areas of the Software
Section 4.1: New Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 4.2: Modified Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 5: Additional Supporting Information
Section 6: Test Results, if applicable
Section 7 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.yml