Fix sampler.py issues creating sequence-score mismatches#15
Open
carlossolugen wants to merge 3 commits intoNatLabRockies:mainfrom
Open
Fix sampler.py issues creating sequence-score mismatches#15carlossolugen wants to merge 3 commits intoNatLabRockies:mainfrom
carlossolugen wants to merge 3 commits intoNatLabRockies:mainfrom
Conversation
Collaborator
|
Sorry for the lengthy time it took to get around to this PR! Not much free time these days..
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Identified issues and corrected them that led to sequences not matching the scores the sampler returned, as well as sequences being accepted despite accepted being false as a side effect of the bug in how state was kept across the sampling.