Skip to content

Conversation

@RobJY
Copy link
Contributor

@RobJY RobJY commented Feb 26, 2025

Getting close to being ready to merge. Making this draft PR to test against lint.

@RobJY RobJY self-assigned this Feb 26, 2025
@github-actions
Copy link

github-actions bot commented Feb 26, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-03 17:05 UTC

@RobJY
Copy link
Contributor Author

RobJY commented Feb 26, 2025

I'm getting errors around the iframes I just added:

docs/hpc/07_containers/02_containers.md
  1:1  error  TypeError: Cannot read properties of undefined (reading 'mdxJsxTagStack')
    at Object.enterMdxJsxTag (file:///home/runner/work/rts-docs-dev/rts-docs-dev/node_modules/mdast-util-mdx-jsx/lib/index.js:161:20)
    at compile (file:///usr/local/lib/node_modules/remark-cli/node_modules/mdast-util-from-markdown/lib/index.js:352:40)
    at fromMarkdown (file:///usr/local/lib/node_modules/remark-cli/node_modules/mdast-util-from-markdown/lib/index.js:187:29)
    at parser (file:///usr/local/lib/node_modules/remark-cli/node_modules/remark-parse/lib/index.js:18:12)
    at Function.parse (file:///usr/local/lib/node_modules/remark-cli/node_modules/unified/lib/index.js:273:12)
    at parse (file:///usr/local/lib/node_modules/remark-cli/node_modules/unified-engine/lib/file-pipeline/parse.js:50:36)
    at wrapped (file:///usr/local/lib/node_modules/remark-cli/node_modules/trough/lib/index.js:160:27)
    at next (file:///usr/local/lib/node_modules/remark-cli/node_modules/trough/lib/index.js:86:23)
    at done (file:///usr/local/lib/node_modules/remark-cli/node_modules/trough/lib/index.js:194:7)
    at file:///usr/local/lib/node_modules/remark-cli/node_modules/unified-engine/lib/file-pipeline/read.js:39:7

I'm also getting one for docs/hpc/03_storage/06_data_management.md

any idea how I fix these? Seems like the iframe code is the same as elsewhere in the document, so I'm confused.

@s-sajid-ali
Copy link
Member

s-sajid-ali commented Feb 26, 2025

I'm getting errors around the iframes I just added:

Can you rename them to .mdx ? (https://mdxjs.com/)

Additional context: https://docusaurus.io/docs/markdown-features#mdx-vs-commonmark

@RobJY RobJY requested a review from s-sajid-ali February 26, 2025 23:43
@RobJY RobJY marked this pull request as ready for review February 26, 2025 23:44
@RobJY
Copy link
Contributor Author

RobJY commented Feb 26, 2025

Oh, of course. I remember reading about the mdx extension, but didn't realize I'd need it for iframes. Thanks so much for pointing that out!

Ok, I think it's ready for review. Please let me know if there's anything I missed. Thanks!

The vast file system is available on all nodes (compute, login, etc.) on Greene as well as Data Transfer Node (gDTN).

:::note
- There are ***No Back ups*** of the vastsc file system. ***Files that were deleted accidentally or removed due to storage system failures CAN NOT be recovered.***
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as for the scratch nested admonition

@s-sajid-ali
Copy link
Member

s-sajid-ali commented Feb 28, 2025

The data management page might be a better first page as it introduces all the concepts of how one goes about managing data on a HPC cluster. The details about specific storage systems and transfer methods can then follow as subsequent sections.

Let me know if you think it might be better to reorganize the page ordering.

@RobJY
Copy link
Contributor Author

RobJY commented Feb 28, 2025

I'm sure it needs to be reorganized. Your suggestion sounds great.
I just dumped the pages in the directory as I worked on them. Please let me know if you've got a suggested reordering and I'll take a look at it too. Thanks!

@RobJY
Copy link
Contributor Author

RobJY commented Feb 28, 2025

I guess we also need more up to date storage info, like has the amount of storage on GPFS changed, how much VAST storage do we have, wow big is RSP, etc.
Maybe that's better added to a new ticket?

@s-sajid-ali
Copy link
Member

Maybe that's better added to a new ticket?

Sounds good to me.

@RobJY
Copy link
Contributor Author

RobJY commented Feb 28, 2025

Cool, I started that ticket and will add to it as we finish this up and as I work through the usability ticket.

@RobJY
Copy link
Contributor Author

RobJY commented Mar 3, 2025

@s-sajid-ali Thanks for all the great suggestions!
I've pushed an update that incorporates them and some changes I mentioned in the resolved comments above. Please let me know if you'd rather I not pull out those top bullet list items into a separate warning or would like any other changes.

@s-sajid-ali
Copy link
Member

Looks good to me.

@s-sajid-ali s-sajid-ali merged commit 6b334cc into main Mar 3, 2025
4 checks passed
@RobJY
Copy link
Contributor Author

RobJY commented Mar 3, 2025

Cool, thanks @s-sajid-ali !

@RobJY RobJY mentioned this pull request Mar 3, 2025
17 tasks
@s-sajid-ali s-sajid-ali deleted the storage branch March 3, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants