-
Notifications
You must be signed in to change notification settings - Fork 3
Redirect Enter key to search results page #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
@Yolo1105 Clicking enter does indeed load a "search" page, but page not found. |
|
Better. Can we remove the hourglass from the search bar on the /search page. For me, it overlaps with the text. Either that or move the search bar text over to the right. |
049c7b6 to
9a9ec40
Compare
|
@Yolo1105 the overlap is fixed. Looking closer at the search results it doesn't seem to be ranked correctly. I enter ssh and the search box before clicking enter shows me "ssh keys" but when I click enter I get a link for dataproc. Doesn't seem ranked or highlights in the blurb why i'm being shown the link. |
|
@Yolo1105 Almost there. |
|
@s-sajid-ali I think this looks good now for review. What do you think? |
|
@yolo110: Would it be possible to highlight the query text? |
|
@s-sajid-ali since Mohan is no longer working for us, I think this is as far as it gets with this. Looks better than what we have now. |
|
Sounds good, we just have to rebase this over main and it will be good to merge. |
/searchpage that displays all search results/search?q=queryon Enter