Skip to content

Conversation

@Yolo1105
Copy link
Contributor

  • Changes search behavior so pressing Enter opens a full results page instead of jumping to the first result
  • Added /search page that displays all search results
  • Modified SearchBar to navigate to /search?q=query on Enter
  • Preserved dropdown suggestions for quick navigation

@github-actions
Copy link

github-actions bot commented Oct 25, 2025

PR Preview Action v1.6.3

🚀 View preview at
https://NYU-RTS.github.io/rts-docs/pr-preview/pr-205/

Built to branch gh-pages at 2025-12-19 19:52 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@genericdata
Copy link
Contributor

@Yolo1105 Clicking enter does indeed load a "search" page, but page not found.

@genericdata
Copy link
Contributor

Better. Can we remove the hourglass from the search bar on the /search page. For me, it overlaps with the text. Either that or move the search bar text over to the right.

@Yolo1105 Yolo1105 force-pushed the feature/search-results-page branch from 049c7b6 to 9a9ec40 Compare October 29, 2025 20:36
@genericdata
Copy link
Contributor

@Yolo1105 the overlap is fixed. Looking closer at the search results it doesn't seem to be ranked correctly. I enter ssh and the search box before clicking enter shows me "ssh keys" but when I click enter I get a link for dataproc. Doesn't seem ranked or highlights in the blurb why i'm being shown the link.

@genericdata
Copy link
Contributor

@Yolo1105 Almost there. 
When I enter "torch" and press enter I get what looks to be great. The search bar is appropriate and the results are appropriate. 
Now I go back to the top right search bar. I enter another search term like "ssh" and press enter. I do get the appropriate search items, BUT the search bar on the search page does not update. Please fix.

@genericdata
Copy link
Contributor

@s-sajid-ali I think this looks good now for review. What do you think?

@s-sajid-ali
Copy link
Member

@yolo110: Would it be possible to highlight the query text?

@genericdata
Copy link
Contributor

@Yolo1105 did you finalize the highlight request in your last pull request?
cea3306

@genericdata
Copy link
Contributor

@s-sajid-ali since Mohan is no longer working for us, I think this is as far as it gets with this. Looks better than what we have now.

@s-sajid-ali
Copy link
Member

Sounds good, we just have to rebase this over main and it will be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants