Skip to content

Shrink the inline storage in connect_awaitable #1974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericniebler merged 26 commits into from
Apr 3, 2026
+1,159 −135
Merged

Shrink the inline storage in connect_awaitable #1974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6fb789b
Shrink the inline storage in connect_awaitable
ispeters Mar 30, 2026
db2f2b8
Credit Lewis in the source, too
ispeters Mar 30, 2026
bffef39
Code review feedback
ispeters Mar 30, 2026
38f2817
Address self-review comments
ispeters Mar 31, 2026
27bdd56
Defer construction of the awaitable state
ispeters Mar 31, 2026
231c707
Shrink storage to four pointers, maybe fix GCC
ispeters Mar 31, 2026
2991cd7
Eliminate padding in __opstate
ispeters Mar 31, 2026
33985c5
Conditionally store the awaitable and awaiter
ispeters Mar 31, 2026
1ef38a5
Add tests for connect_awaitable
ispeters Apr 1, 2026
1689f62
Test exception handling in connect_awaitable
ispeters Apr 1, 2026
9a14392
Fix GCC builds
ispeters Apr 1, 2026
a10140a
Fix misplaced [[no_unique_address]]
ispeters Apr 2, 2026
56a885e
Re-format and fix template-template bug
ispeters Apr 2, 2026
bc3e13f
Missed a spot
ispeters Apr 2, 2026
fc1fe0c
Add debug output
ispeters Apr 2, 2026
0110d38
Hopefully fix most broken builds
ispeters Apr 3, 2026
f92b4d7
Make the MSVC build more verbose
ispeters Apr 3, 2026
6d73ac8
more verbose CI failures on Windows
ericniebler Apr 3, 2026
7294ba4
Fix typo in connect_awaitable
ispeters Apr 3, 2026
828c3bb
Fix formatting
ispeters Apr 3, 2026
2f38e0b
Update compiler detection
ispeters Apr 3, 2026
76bebc4
Fix MSVC build
ispeters Apr 3, 2026
d1c3308
Try a synthetic coroutine frame
ispeters Apr 3, 2026
6271495
Shrink the opstate by a pointer
ispeters Apr 3, 2026
f9f3181
Feedback
ispeters Apr 3, 2026
0995025
By security at the cost of a pointer
ispeters Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test-windows.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Invoke-NativeCommand cmake -B $BuildDirectory -G Ninja `
"-DCMAKE_MSVC_DEBUG_INFORMATION_FORMAT:STRING=Embedded" `
"-DSTDEXEC_ENABLE_ASIO:BOOL=TRUE" `
"-DSTDEXEC_ASIO_IMPLEMENTATION:STRING=boost" `
"-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON" `
"-DSTDEXEC_BUILD_TESTS:BOOL=TRUE" .
Invoke-NativeCommand cmake --build $BuildDirectory
Invoke-NativeCommand ctest --test-dir $BuildDirectory
Invoke-NativeCommand ctest --test-dir $BuildDirectory --output-on-failure --verbose --timeout 60
Loading
Loading