Skip to content

chore(starters): add agents files#89

Open
coryrylan wants to merge 1 commit into
mainfrom
topic-starter-skills
Open

chore(starters): add agents files#89
coryrylan wants to merge 1 commit into
mainfrom
topic-starter-skills

Conversation

@coryrylan
Copy link
Copy Markdown
Collaborator

@coryrylan coryrylan commented May 15, 2026

Summary by CodeRabbit

  • Documentation
    • Added integration guides for all Elements starters across 16 environments (Angular, React, Vue, Svelte, SolidJS, Nuxt, Next.js, Eleventy, Eleventy-SSR, Hugo, Go, TypeScript, MPA, bundles, import-maps, and Lit library). Each guide details wiring/setup conventions, framework-specific template/JSX/TSX rules, asset/registration points, and recommended verification commands.

Review Change Stack

@coryrylan coryrylan requested a review from johnyanarella May 15, 2026 21:57
@coryrylan coryrylan self-assigned this May 15, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

📝 Walkthrough

Walkthrough

This PR adds 16 AGENTS.md documentation files across starter projects, each providing framework- or build-specific integration guidance for wiring NVIDIA Elements: registration points, template/JSX/TSX syntax conventions, CSS/theme placement, SSR/hydration notes where applicable, and verification commands.

Changes

Starter Framework Integration Documentation

Layer / File(s) Summary
Frontend Framework Starters
projects/starters/react/AGENTS.md, projects/starters/vue/AGENTS.md, projects/starters/angular/AGENTS.md, projects/starters/solidjs/AGENTS.md, projects/starters/svelte/AGENTS.md, projects/starters/nuxt/AGENTS.md, projects/starters/nextjs/AGENTS.md
Framework-specific guides covering Elements registration location, custom element type augmentation, global CSS/theme placement, template syntax conventions (JSX/TSX props, Vue directives, Angular schemas, Svelte/Solid bindings), reactive forms notes, and build/lint verification steps.
Build and Library Starters
projects/starters/typescript/AGENTS.md, projects/starters/mpa/AGENTS.md, projects/starters/lit-library/AGENTS.md, projects/starters/bundles/AGENTS.md, projects/starters/importmaps/AGENTS.md
Guides for Vite/TypeScript packaging, MPA entry wiring and view transitions, Lit library export/define conventions, static bundle loading and tree-shaking trade-offs, and import-map copy/script maintenance plus verification commands.
Server-Rendered and Template Starters
projects/starters/go/AGENTS.md, projects/starters/hugo/AGENTS.md, projects/starters/eleventy/AGENTS.md, projects/starters/eleventy-ssr/AGENTS.md
Server/template integration guidance: Go html/template wiring, Hugo render hooks and Goldmark constraints, Eleventy layout/markdown-it attribute rules, and Eleventy SSR hydration/module ordering and build verification steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

scope(docs)

Suggested reviewers

  • johnyanarella
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(starters): add agents files' accurately describes the main change—adding AGENTS.md documentation files across all starter projects.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch topic-starter-skills

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@projects/starters/eleventy/AGENTS.md`:
- Line 16: Update the sentence that currently reads "Let raw `nve-*` HTML pass
through markdown only when the page intentionally owns that markup." to
capitalize the markup name so it reads "Let raw `nve-*` HTML pass through
Markdown only when the page intentionally owns that markup." — locate the exact
string in AGENTS.md and replace "markdown" with "Markdown".

In `@projects/starters/nextjs/AGENTS.md`:
- Line 1: Update the product name in the markdown heading to the canonical
“Next.js”: replace the header string "Elements NextJS Starter" with "Elements
Next.js Starter" so the title matches the rest of the document; look for the
top-level heading text "Elements NextJS Starter" in AGENTS.md and update its
capitalization/punctuation to "Next.js".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 8fc53f73-1ff3-44b1-8768-ca8a2f3739b8

📥 Commits

Reviewing files that changed from the base of the PR and between e8e3187 and 0886a58.

📒 Files selected for processing (16)
  • projects/starters/angular/AGENTS.md
  • projects/starters/bundles/AGENTS.md
  • projects/starters/eleventy-ssr/AGENTS.md
  • projects/starters/eleventy/AGENTS.md
  • projects/starters/go/AGENTS.md
  • projects/starters/hugo/AGENTS.md
  • projects/starters/importmaps/AGENTS.md
  • projects/starters/lit-library/AGENTS.md
  • projects/starters/mpa/AGENTS.md
  • projects/starters/nextjs/AGENTS.md
  • projects/starters/nuxt/AGENTS.md
  • projects/starters/react/AGENTS.md
  • projects/starters/solidjs/AGENTS.md
  • projects/starters/svelte/AGENTS.md
  • projects/starters/typescript/AGENTS.md
  • projects/starters/vue/AGENTS.md

Comment thread projects/starters/eleventy/AGENTS.md
Comment thread projects/starters/nextjs/AGENTS.md
Signed-off-by: Cory Rylan <crylan@nvidia.com>
@coryrylan coryrylan force-pushed the topic-starter-skills branch from 0886a58 to 7c44923 Compare May 18, 2026 00:31
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@projects/starters/nuxt/AGENTS.md`:
- Around line 8-10: Reword the adjacent bullets so they don't all start with
"Keep": change the first to something like "Retain global `htmlAttrs` for
`lang`, `nve-theme`, and `nve-transition` in `nuxt.config.ts`", the second to
"Preserve Elements Vue type references in `env.d.ts`", and the third to "Import
global Elements CSS in `app/app.vue`"; update the AGENTS.md bullets accordingly
to satisfy Vale linting while preserving the same intent and references
(`nuxt.config.ts`, `env.d.ts`, `app/app.vue`, `htmlAttrs`).

In `@projects/starters/react/AGENTS.md`:
- Around line 8-10: The three adjacent bullets all begin with "Keep", which
tripped Vale style lint; edit the AGENTS.md bullet list so the items use varied
openers (e.g., change one or two bullets to alternatives like "Place `nve-theme`
and `nve-transition` in `src/index.html`" and "Add JSX custom element type
augmentation in `src/global.d.ts`") while preserving the same file references
and intent for "Keep global theme CSS in `src/index.css`", the
`nve-theme`/`nve-transition` mention, and the JSX augmentation line.

In `@projects/starters/solidjs/AGENTS.md`:
- Around line 8-10: Adjacent bullet items that start with the same verb (e.g.,
the three bullets describing where to keep Elements JSX augmentation, global
Elements CSS, and theme attributes) should vary their opening words to satisfy
Vale lint rules; edit the bullets that reference "Elements JSX augmentation in
`src/types.d.ts`", "global Elements CSS in `src/index.css`", and "theme
attributes on `src/index.html`" to use different starters (for example, change
one "Keep" to "Place" or "Move" and another to "Store/Define") so the adjacent
bullets no longer all begin with the same word, and make the same change for the
other repeated group mentioned in the comment.

In `@projects/starters/svelte/AGENTS.md`:
- Around line 8-10: Reword one of the adjacent bullets that begin with "Keep" to
avoid repeating the same lead verb; for example, change the bullet "Keep theme
attributes on `src/index.html`" to a rephrasing such as "Place theme attributes
in `src/index.html`" or "Store theme attributes in `src/index.html`" so that the
three bullets no longer all start with "Keep" and Vale linting will pass.

In `@projects/starters/vue/AGENTS.md`:
- Around line 8-10: Reword the repeated bullet-starter words in the listed items
to avoid Vale/write-good warnings: change the three bullets that begin with
"Keep" (referencing custom-elements-vue.d.ts, env.d.ts, tsconfig.app.json and
registering elements in src/App.vue) to use varied verbs (e.g., "Reference",
"Include", "Register" or similar) and do the same for the other group at lines
15–17 so each consecutive bullet starts with a different word while preserving
the original meaning.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: a4513fc3-203a-4c6e-a2f2-54625419726e

📥 Commits

Reviewing files that changed from the base of the PR and between 0886a58 and 7c44923.

📒 Files selected for processing (16)
  • projects/starters/angular/AGENTS.md
  • projects/starters/bundles/AGENTS.md
  • projects/starters/eleventy-ssr/AGENTS.md
  • projects/starters/eleventy/AGENTS.md
  • projects/starters/go/AGENTS.md
  • projects/starters/hugo/AGENTS.md
  • projects/starters/importmaps/AGENTS.md
  • projects/starters/lit-library/AGENTS.md
  • projects/starters/mpa/AGENTS.md
  • projects/starters/nextjs/AGENTS.md
  • projects/starters/nuxt/AGENTS.md
  • projects/starters/react/AGENTS.md
  • projects/starters/solidjs/AGENTS.md
  • projects/starters/svelte/AGENTS.md
  • projects/starters/typescript/AGENTS.md
  • projects/starters/vue/AGENTS.md

Comment thread projects/starters/nuxt/AGENTS.md
Comment thread projects/starters/react/AGENTS.md
Comment thread projects/starters/solidjs/AGENTS.md
Comment thread projects/starters/svelte/AGENTS.md
Comment thread projects/starters/vue/AGENTS.md
## Verification

- Run `pnpm run build` in `projects/starters/angular` after schema, import, or template changes.
- Run `pnpm run lint` when editing TypeScript, HTML templates, or CSS.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each starter that the CLI/MCP exposes in the MR gets a AGENTS.md with minimal guidance on any elements + starter integration specific points to call out. I tried to keep these focused on the integration points as I don't want to duplicate context already provided by our mcp/cli/skills

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant