Add explicit CUDA graph construction API (GraphDef, GraphNode)#1772
Open
Andy-Jost wants to merge 1 commit intoNVIDIA:mainfrom
Open
Add explicit CUDA graph construction API (GraphDef, GraphNode)#1772Andy-Jost wants to merge 1 commit intoNVIDIA:mainfrom
Andy-Jost wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Andy-Jost
added
feature
Andy-Jost
added
feature
Contributor
Author
|
/ok to test |
|
Andy-Jost
force-pushed
the
explicit-graph-api
branch
from
f07dba3 to
6cb61af
Compare
Andy-Jost
changed the title
Contributor
Author
|
/ok to test |
Andy-Jost
force-pushed
the
explicit-graph-api
branch
from
6cb61af to
49efb6b
Compare
Contributor
Author
|
/ok to test |
cpcloud
requested changes
Mar 16, 2026
Contributor
cpcloud
left a comment
cpcloud
left a comment
There was a problem hiding this comment.
The explicit graph model looks promising, but I found a few correctness/API issues that make me uncomfortable approving this as-is. The biggest ones are entry-node identity, GraphDef() failing before CUDA init in a fresh process, and the ctypes host-callback lifetime. I left inline comments with concrete fixes.
Andy-Jost
force-pushed
the
explicit-graph-api
branch
2 times, most recently
from
86f7179 to
310b994
Compare
Introduces GraphDef and GraphNode types for explicit CUDA graph construction, with a full node hierarchy, shared instantiation helper with GraphCompleteOptions support, and comprehensive tests. Made-with: Cursor
Andy-Jost
force-pushed
the
explicit-graph-api
branch
from
310b994 to
b965385
Compare
Contributor
Author
|
/ok to test |
Contributor
Author
|
@cpcloud The latest upload fixes the issues you pointed out, except the CUDA init problem, which needs clarification. |
Contributor
|
@Andy-Jost Since your PR is not a draft you shouldn't need ok-to-test anymore. |
cpcloud
approved these changes
Mar 17, 2026
Contributor
cpcloud
left a comment
cpcloud
left a comment
There was a problem hiding this comment.
Re-reviewed the latest head. The earlier GraphNode identity and callback lifetime issues are fixed, and I do not have any remaining blocking review items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GraphDefandGraphNodetypes for explicit CUDA graph construction, complementing the existing stream-capture path viaGraphBuilder.GraphBuilder.complete()andGraphDef.instantiate()supportGraphCompleteOptions, and removes the pre-CUDA 12.0cuGraphInstantiateWithFlagsfallback.Depends on #1762 (merged).
Closes #1317.
Changes
_graphdef.pxd/_graphdef.pyxcontainingGraphDef,GraphNode, and all node subclasses_graph/__init__.py: Extracted_instantiate_graph()helper; updated exports for new typesresource_handles.cpp/.hpp: Added graph and graph-node RAII handles,HandleRegistryfor reverse handle lookup_resource_handles.pxd/.pyx: Cython declarations for graph handle types_memory/_buffer.pyx: Graph memory allocation support_utils/cuda_utils.pxd/.pyx: Utility additions for graph constructionGraphCompleteOptionsvariantsTest plan
test_explicit.py,test_explicit_errors.py,test_explicit_integration.py,test_explicit_lifetime.pytest_object_protocols.py