refactor(examples): standardize example file structure#1770
Open
cpcloud wants to merge 1 commit intoNVIDIA:mainfrom
Open
refactor(examples): standardize example file structure#1770cpcloud wants to merge 1 commit intoNVIDIA:mainfrom
cpcloud wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Normalize example description headers and entry points so the core and bindings examples follow the same executable layout ahead of the broader examples polish work. Made-with: Cursor
|
Collaborator
|
Drive-by action: I just triggered a rerun of a failed Windows build (infrastructure flake). Hope that's helpful. |
Contributor
Author
|
Yup, thanks! |
rwgk
reviewed
Mar 16, 2026
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
I looked at the changes pretty carefully: apart from the loss of the very useful comment block in cuda_core/examples/gl_interop_plasma.py it looks great to me.
| # | ||
| # ################################################################################ | ||
| # | ||
| # What this example teaches |
Collaborator
There was a problem hiding this comment.
The change to the banner looks good, but it's a significant loss that all the other useful and carefully structured information is simply removed. Could we keep it, maybe below the banner?
rwgk
approved these changes
Mar 17, 2026
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
Approving so you can merge this in your morning; please see #1770 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda_core/examplesandcuda_bindings/examplesmain()andif __name__ == "__main__"consistently, including moving the remainingcuda_coremodule-level execution intomain()cuda_bindingsexample layout while adding the missing direct-execution guard forconjugateGradientMultiBlockCG_test.pyFollow Ups
Closes #1674
Made with Cursor