Cython .pth file support for pixi path dependencies #1562
Merged
+516
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rparolin
changed the title
Collaborator
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
cpcloud
approved these changes
Feb 3, 2026
Contributor
cpcloud
left a comment
cpcloud
left a comment
There was a problem hiding this comment.
I ... kind of love and hate this PR.
| # If cuda-bindings isn't available yet, we can't add the path | ||
| # This might happen in some build scenarios, but it's okay - the | ||
| # wildcard dependency will work in those cases | ||
| print("cuda-bindings not found in current environment, skipping .pth modification") |
Contributor
There was a problem hiding this comment.
Suggested change
| print("cuda-bindings not found in current environment, skipping .pth modification") |
I'm not sure that's helpful here.
Collaborator
Author
There was a problem hiding this comment.
I'd err on the side of printing out an error message rather than failing silently.
Contributor
There was a problem hiding this comment.
In that case, let's also print to stderr (via file=sys.stderr)
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>
Collaborator
Author
|
/ok to test |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
cuda-coredepends oncuda-bindingsat build time and needs access to Cython.pxdheader files. Previously, we used wildcard dependencies (cuda-bindings = "*") because Cython cannot find.pxdfiles through Python's editable install meta path finders ([Cython issue #7326] cython/cython#7326)). This meant pixi couldn't track local dependencies, so rebuilds had to be managed manually.Solution
Implemented the .pth file workaround from scikit-build-core PR#516:
sys.pathso Cython can find.pxdfiles during compilation.pthfile to maintain the path for importsThis enables changing from:
cuda-bindings = "*" # No dependency tracking
To:
cuda-bindings = { path = "../cuda_bindings" } # Full dependency tracking