-
Notifications
You must be signed in to change notification settings - Fork 242
Enable apt proxy caching; skip hosted Windows builds #1552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rwgk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I noticed before that downloading Windows wheels from PyPI (for pathfinder testing) was very slow (maybe even rate limiting).
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
|
You'll need to exclude the GitHub hosted runners from using that action. It only works on our self-hosted runners. |
|
For some reason I had thought that we moved our Windows CPU builds to the CPU pool. I'll address it, thanks. |
|
/ok to test |
Unfortunately it failed because we're still on GitHub hosted Windows CPU runners. Hopefully we can move to self hosted CPU runners sooner than later. |
|
I think it's still a big gain. This is the slow step I had in mind, in If I'm doing the math correctly, that's a whopping 2.3 GB; see below; I didn't actually realize before it's that much. Luckily that's in the file where we now have This is what that pip install command pulls in: |
Description
closes N/A
Checklist