[CUB] Replace Shuffle(Up|Down|Index) with cuda::device::warp_shuffle - RadixSort only#8395
Open
fbusato wants to merge 2 commits intoNVIDIA:mainfrom
Open
[CUB] Replace Shuffle(Up|Down|Index) with cuda::device::warp_shuffle - RadixSort only#8395fbusato wants to merge 2 commits intoNVIDIA:mainfrom
Shuffle(Up|Down|Index) with cuda::device::warp_shuffle - RadixSort only#8395fbusato wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Apr 14, 2026
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
The code changes look good to me. However, it looks like there were no benchmark results
Contributor
|
Perf results look ok on sm120, but not on the other architectures. |
Contributor
Author
It is fun that I just checked the SASS for Radix Sort on SM90, SM100, SM120 for all benchmark types ( If we are not able to get stable performance comparison even for identical SASS, we have a problem (@gevtushenko ) Coincidence: NVIDIA/nvbench#316 (comment) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split
Shuffle(Up|Down|Index)withcuda::device::warp_shuffle#8159The change only affects RadixSort routines. This helps to isolate potential performance regressions