-
Notifications
You must be signed in to change notification settings - Fork 657
Feat/cp nvshmem enhanced #2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Knight-of-Thunder
wants to merge
24
commits into
NVIDIA:main
Choose a base branch
from
ETOgaosion:feat/cp_nvshmem_enhanced
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/cp nvshmem enhanced #2737
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
0289e76
Changed VERSION to 2.7.0
ptrendx 34150d1
[JAX] Error checking for mesh resource and update GemmPrimitive to us…
jberchtold-nvidia 9f065fa
[PyTorch] Avoid garbage collection when capturing a CUDA Graph (#2092)
timmoon10 3a4136b
Fix incorrect version checks for atomic GEMM (#2095)
timmoon10 0168c26
[ TE-JAX ] Expose cp_strategy argument to DPA api (#2090)
kocchop e94041a
[PyTorch] Debug Mcore wgrad fusion with te.ops (#2097)
timmoon10 c638ac7
[JAX] Add Shardy warning in GEMM custom call (#2101)
phu0ngng 4572dbe
Revert "[Common] PDL for Quantization Kernels" (#2114)
jberchtold-nvidia d2615d1
Bump cuDNN FE to 1.14.0 (#2072)
vcherepanov-nv 58c3ac8
Revert "[Common] PDL for Blockwise Quantization" (#2115)
jberchtold-nvidia f8d2c50
[PyTorch] Add test for TRT integration + fix for mxfp8 export (#2083)
pggPL d7874aa
Add cuBLASMp-backed GEMM-like API to TE common (#1824)
mk-61 1d1e8ef
Further relax constraints to cuDNN 9.13 for disabling fused attn for …
KshitijLakhani 9cd6d16
Temporarily remove comm_gemm tests (#2133)
vcherepanov-nv fedd9dd
[PyTorch] Disable determinism for sm100 (#2130)
cyanguwa d5858d4
dev-base initialize: with version change and log verify
miceforrat 7c17ea4
Merge pull request #1 from ETOgaosion/dev-base
miceforrat 3bf99b5
feat: pure nvshmem comm based cp
Knight-of-Thunder 2cb93fb
Merge pull request #2 from ETOgaosion/feat/nvshmem_based_cp
ETOgaosion 1c046e2
feat: store fa result in nvshmem
Knight-of-Thunder f63d3c3
refactor: create a new stream for communication and use pybindings to…
Knight-of-Thunder 4f77ecf
fix: ensure the get is completed before computation by using sync
Knight-of-Thunder cee55e4
refactor: use NVSHMEM pybindings in bwd
Knight-of-Thunder 1c88f8f
feat: context_parallel_nvshmem_enhanced
Knight-of-Thunder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule cudnn-frontend
updated
40 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.7.0.dev0 | ||
| 2.7.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Copyright (c) 2022-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # See LICENSE for license information. | ||
|
|
||
| set -e | ||
|
|
||
| # Find TE | ||
| : ${TE_PATH:=/opt/transformerengine} | ||
| TE_LIB_PATH=$(pip3 show transformer-engine | grep -E "Location:|Editable project location:" | tail -n 1 | awk '{print $NF}') | ||
| export LD_LIBRARY_PATH=$TE_LIB_PATH:$LD_LIBRARY_PATH | ||
|
|
||
| cd $TE_PATH/tests/cpp | ||
| cmake -GNinja -S. -Bbuild | ||
| cmake --build build | ||
| mpirun --allow-run-as-root --np 4 --oversubscribe ./build/comm_gemm/test_comm_gemm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # Copyright (c) 2022-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # See LICENSE for license information. | ||
|
|
||
|
|
||
| pip3 install onnxruntime==1.20.1 | ||
| pip3 install onnxruntime_extensions==0.13.0 | ||
|
|
||
| : ${TE_PATH:=/opt/transformerengine} | ||
|
|
||
| python3 -m pytest --tb=auto $TE_PATH/tests/pytorch/test_onnx_export.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Copyright (c) 2022-2025, NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # | ||
| # See LICENSE for license information. | ||
|
|
||
| add_executable(test_comm_gemm | ||
| test_comm_gemm.cu | ||
| ../test_common.cu) | ||
|
|
||
| find_package(OpenMP REQUIRED) | ||
| find_package(MPI REQUIRED) | ||
| find_library(NCCL_LIB | ||
| NAMES nccl libnccl | ||
| PATH_SUFFIXES lib | ||
| REQUIRED) | ||
| target_include_directories(test_comm_gemm PRIVATE ${MPI_CXX_INCLUDE_PATH} $ENV{CUBLASMP_HOME}/include) | ||
| target_link_libraries(test_comm_gemm PUBLIC CUDA::cuda_driver CUDA::cudart GTest::gtest ${TE_LIB} CUDA::nvrtc CUDNN::cudnn MPI::MPI_CXX ${NCCL_LIB} OpenMP::OpenMP_CXX) | ||
|
|
||
| include(GoogleTest) | ||
| gtest_discover_tests(test_comm_gemm DISCOVERY_TIMEOUT 600) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug
printleft in build scriptThis
print("CMAKE_FLAGS:", cmake_flags[-2:])is a debug statement that will be emitted on every build whereNVTE_WITH_CUBLASMP=1. It should be removed before merging to keep build output clean.