-
Notifications
You must be signed in to change notification settings - Fork 659
[PyT] [Common] Enable sm120 support for fused attn if cuDNN is 9.18.1+ #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KshitijLakhani
wants to merge
14
commits into
NVIDIA:main
Choose a base branch
from
KshitijLakhani:klakhani/maint/sm120-thd-flash-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−47
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
fa2e2cb
Enable sm120 support for fused attn if cuDNN is 9.18.1+
KshitijLakhani bea8bbb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b2f5864
Force intermediate tensors such as S, Sum_Exp, and Max to be BHS1 sha…
KshitijLakhani 076420d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8753fc2
Add support for sm120 correct batch, seq dims
KshitijLakhani 0336d2a
Add support for sm120 BHS1 style max logit even QKV are THD to avoid …
KshitijLakhani d24eb35
Disable fused and flash attn for sm120 filter:kv cache
KshitijLakhani e2e89d4
For CP P2P attn, set softmax_lse_in_packed_format to False if sm120+
KshitijLakhani 5a8ecb9
Assert in TE if T3HD/TH3D layout is used on sm120 before cuDNN F16 sd…
KshitijLakhani 7ca7564
Modify is_ragged_q && cudnn_runtime_version >= 90600 check to also in…
KshitijLakhani 3227016
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 46c6e60
nit: Code clean up
KshitijLakhani b75348c
Disable fused attn for T3HD and TH3D
KshitijLakhani 75ef6d9
Merge branch 'main' into klakhani/maint/sm120-thd-flash-support
KshitijLakhani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing period in forward error message
The forward error message is missing a period that is present in the corresponding backward error message (line 748). Minor inconsistency but worth fixing for uniformity.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!