Skip to content

[https://nvbugs/6043312][fix] fix_mooncake_transfer_agent_binding#12723

Merged
chuangz0 merged 2 commits intoNVIDIA:mainfrom
chuangz0:fix_mooncake_transfer_agent_binding
Apr 11, 2026
Merged

[https://nvbugs/6043312][fix] fix_mooncake_transfer_agent_binding#12723
chuangz0 merged 2 commits intoNVIDIA:mainfrom
chuangz0:fix_mooncake_transfer_agent_binding

Conversation

@chuangz0
Copy link
Copy Markdown
Collaborator

@chuangz0 chuangz0 commented Apr 3, 2026

Summary by CodeRabbit

  • Tests
    • Removed waiver for a previously skipped test, enabling it to run during testing cycles
    • Updated test implementation to use standardized test setup patterns

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@chuangz0 chuangz0 force-pushed the fix_mooncake_transfer_agent_binding branch from aa2957d to b48a2d8 Compare April 3, 2026 02:24
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bdb74d6b-a175-42e4-8a96-02ce47af1aec

📥 Commits

Reviewing files that changed from the base of the PR and between b8c3225 and cb29266.

📒 Files selected for processing (2)
  • tests/integration/test_lists/waives.txt
  • tests/unittest/bindings/test_transfer_agent_bindings.py
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

A test entry is removed from the waives list and the corresponding test file is updated to use the factory function pattern for Mooncake agent instantiation instead of direct constructor calls, with minor whitespace cleanup.

Changes

Cohort / File(s) Summary
Waive List Update
tests/integration/test_lists/waives.txt
Removed a single waived test entry for TestMooncakeFunctionalTransfer::test_mooncake_wait_in_progress_on_zero_timeout with its SKIP reason reference.
Mooncake Agent Factory Refactoring
tests/unittest/bindings/test_transfer_agent_bindings.py
Updated agent instantiation to use factory function tab.make_transfer_agent("mooncake", config_*) pattern for agent_a and agent_b in two test cases; removed blank lines near pytestmark assignment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely empty, containing only the template structure with no actual explanation of changes, test coverage, or checklist completion details filled in. Fill in the Description section explaining what the fix does and why, the Test Coverage section listing relevant tests, and confirm checklist items were actually reviewed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format with NVBugs ID and type [fix], clearly indicating a fix for Mooncake transfer agent binding issues referenced in the bug ticket.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 3, 2026

/bot run

1 similar comment
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 3, 2026

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41560 [ run ] triggered by Bot. Commit: cb29266 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41560 [ run ] completed with state SUCCESS. Commit: cb29266
/LLM/main/L0_MergeRequest_PR pipeline #32471 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0 chuangz0 force-pushed the fix_mooncake_transfer_agent_binding branch from cb29266 to 6aefbd7 Compare April 3, 2026 05:58
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 3, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41601 [ run ] triggered by Bot. Commit: 6aefbd7 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #41601 [ run ] completed with state SUCCESS. Commit: 6aefbd7
/LLM/main/L0_MergeRequest_PR pipeline #32510 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 7, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42016 [ run ] triggered by Bot. Commit: aa7ad7c Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42016 [ run ] completed with state SUCCESS. Commit: aa7ad7c
/LLM/main/L0_MergeRequest_PR pipeline #32863 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0 chuangz0 force-pushed the fix_mooncake_transfer_agent_binding branch from aa7ad7c to 47e0df3 Compare April 8, 2026 02:50
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 8, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42246 [ run ] triggered by Bot. Commit: 47e0df3 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42246 [ run ] completed with state SUCCESS. Commit: 47e0df3
/LLM/main/L0_MergeRequest_PR pipeline #33055 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@chuangz0 chuangz0 force-pushed the fix_mooncake_transfer_agent_binding branch from 47e0df3 to 683ed1d Compare April 9, 2026 02:19
@chuangz0
Copy link
Copy Markdown
Collaborator Author

chuangz0 commented Apr 9, 2026

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42433 [ run ] triggered by Bot. Commit: 683ed1d Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42433 [ run ] completed with state ABORTED. Commit: 683ed1d

Link to invocation

Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
Signed-off-by: Chuang Zhu <111838961+chuangz0@users.noreply.github.com>
@chuangz0 chuangz0 force-pushed the fix_mooncake_transfer_agent_binding branch from 683ed1d to c93bdec Compare April 10, 2026 03:38
@chuangz0
Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42647 [ run ] triggered by Bot. Commit: c93bdec Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42647 [ run ] completed with state SUCCESS. Commit: c93bdec
/LLM/main/L0_MergeRequest_PR pipeline #33359 completed with status: 'SUCCESS'

CI Report

Link to invocation

@chuangz0 chuangz0 merged commit e541a90 into NVIDIA:main Apr 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants