[TRTLLM-9523][chore] e2e tests for KV manager v2 with dis-agg#12689
[TRTLLM-9523][chore] e2e tests for KV manager v2 with dis-agg#12689Shixiaowei02 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
9aaad7d to
dfee1bf
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #41429 [ run ] triggered by Bot. Commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request adds KV-cache resource allocation logic to the disaggregated generation scheduler initialization path, establishes UCX InfiniBand transport exclusion in disaggregated serving environments, and introduces new accuracy tests for KV cache v2 with NIXL backend across multiple GPU configurations. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #41429 [ run ] completed with state
|
dfee1bf to
ae247d1
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #41547 [ run ] triggered by Bot. Commit: |
Signed-off-by: Shixiaowei02 <39303645+Shixiaowei02@users.noreply.github.com>
ae247d1 to
00bd9a9
Compare
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #41607 [ run ] triggered by Bot. Commit: |
| - disaggregated/test_disaggregated.py::test_disaggregated_benchmark_on_diff_backends[DeepSeek-V3-Lite-fp8] | ||
| - accuracy/test_disaggregated_serving.py::TestQwen3_8B::test_nixl_backend | ||
| - accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_nixl_backend | ||
| - accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_kv_cache_v2_nixl_python |
There was a problem hiding this comment.
don't forget to add new tests into qa test list, too
There was a problem hiding this comment.
Will do it. Thanks for the reminder.
|
PR_Github #41607 [ run ] completed with state
|
Summary by CodeRabbit
Tests
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.