Skip to content

autotuner: use torch.ones for e_score_correction_bias when ep_size==1#11282

Closed
lishicheng1996 wants to merge 1 commit intoNVIDIA:release/1.2.0rc6.post1from
lishicheng1996:autotuner/ep-size-one-e-score-correction-bias
Closed

autotuner: use torch.ones for e_score_correction_bias when ep_size==1#11282
lishicheng1996 wants to merge 1 commit intoNVIDIA:release/1.2.0rc6.post1from
lishicheng1996:autotuner/ep-size-one-e-score-correction-bias

Conversation

@lishicheng1996
Copy link

@lishicheng1996 lishicheng1996 commented Feb 4, 2026

When there is no expert parallelism (local_num_experts == num_experts), use torch.ones instead of torch.randn for the dummy e_score_correction_bias tensor in prepare_dummy_topk_and_hook for DeepSeekV3 routing.

Summary by CodeRabbit

  • New Features
    • Added support for specifying a local number of experts in MoE generation, enabling dummy top‑k and routing behavior to adapt to local vs. global expert counts.
    • Introduced deterministic routing bias when local experts match global experts, improving consistency; preserves prior randomized behavior otherwise.
    • Ensures all MoE entry points leverage the new setting for consistent behavior across configurations.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

When there is no expert parallelism (local_num_experts == num_experts),
use torch.ones instead of torch.randn for the dummy e_score_correction_bias
tensor in prepare_dummy_topk_and_hook for DeepSeekV3 routing.
@lishicheng1996 lishicheng1996 requested a review from a team as a code owner February 4, 2026 16:45
@lishicheng1996 lishicheng1996 requested a review from hyukn February 4, 2026 16:45
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

Adds an optional local_num_experts parameter to prepare_dummy_topk_and_hook() function. This parameter enables conditional routing bias generation for DeepSeekV3: when local_num_experts equals num_experts, a ones tensor is used instead of random values. The parameter is propagated through all Moe runner call sites.

Changes

Cohort / File(s) Summary
MoE Custom Operations
tensorrt_llm/_torch/custom_ops/trtllm_gen_custom_ops.py
Added optional local_num_experts parameter to prepare_dummy_topk_and_hook(). Modified DeepSeekV3 routing bias generation to use ones tensor when local_num_experts == num_experts, otherwise preserve random behavior. Updated all Moe runner entry points to pass local_num_experts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive PR description is minimal and lacks required sections; it only states the code change without explaining the issue, solution rationale, or test coverage. Complete the Description and Test Coverage sections to explain why this change is needed, what problem it solves, and which tests validate the fix.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific and directly related to the main change: using torch.ones instead of torch.randn for e_score_correction_bias when ep_size==1.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@svc-trtllm-gh-bot svc-trtllm-gh-bot added the Community want to contribute PRs initiated from Community label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community want to contribute PRs initiated from Community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants