[TRTLLM-10030][perf] beam search (remove GPU sync + fix batching + refactor)#11276
[TRTLLM-10030][perf] beam search (remove GPU sync + fix batching + refactor)#11276ixlmar merged 3 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: ixlmar <206748156+ixlmar@users.noreply.github.com>
|
/bot run |
|
PR_Github #34760 [ run ] triggered by Bot. Commit: |
|
/bot run |
|
PR_Github #34777 [ run ] triggered by Bot. Commit: |
|
PR_Github #34777 [ run ] completed with state
|
|
/bot run |
|
PR_Github #34781 [ run ] triggered by Bot. Commit: |
|
PR_Github #34781 [ run ] completed with state |
|
/bot run |
|
PR_Github #34789 [ run ] triggered by Bot. Commit: |
|
PR_Github #34789 [ run ] completed with state
|
|
/bot run --disable-fail-fast |
|
PR_Github #34941 [ run ] triggered by Bot. Commit: |
|
PR_Github #34941 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #34942 [ run ] triggered by Bot. Commit: |
📝 WalkthroughWalkthroughThis pull request refactors the sampling infrastructure to improve type safety and simplify strategy grouping. Key changes include removing the generator parameter from beam search, introducing Hashable-constrained strategy keys, adding temperature retrieval to strategies, reworking grouped strategy sampling logic, and expanding optional field handling across sampling state dataclasses. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@tensorrt_llm/_torch/pyexecutor/sampler.py`:
- Around line 1530-1532: The method setup_sampler_step has the `@override`
decorator applied twice; remove the redundant decorator so only a single
`@override` precedes the def setup_sampler_step(self, scheduled_requests:
ScheduledRequests): declaration, leaving the rest of the method intact and
ensuring no change to method signature or behavior.
🧹 Nitpick comments (1)
tensorrt_llm/_torch/pyexecutor/sampler.py (1)
1577-1583: Assertions added for beam search buffer initialization.The assertions ensure non-None values before accessing beam search buffers. While these add safety, note that per the codebase learnings, "performance is prioritized over additional validation checks." These assertions will run every iteration during beam search preparation.
Consider whether these could be replaced with a single early check that
_use_beam_searchimplies all buffers are initialized, or moved to_create_storevalidation.
|
/bot run --disable-fail-fast |
1 similar comment
|
/bot run --disable-fail-fast |
|
PR_Github #34967 [ run ] triggered by Bot. Commit: |
|
PR_Github #34967 [ run ] completed with state |
4 participants
Description
In developer testing, this improves
TorchSamplerbeam search iteration time from 20% slower thanTRTLLMSamplerto 14% faster.Detailed changes:
StrategyImpl.get_temperaturereturn_probsargument fromstrategy_grouping_key()Test Coverage
n/a
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
Details
run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]Launch build/test pipelines. All previously running jobs will be killed.
--reuse-test (optional)pipeline-id(OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.--disable-reuse-test(OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-PyTorch-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--test-backend "pytorch, cpp"(OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".--detailed-log(OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.--debug(OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in thestage-listparameter to access the appropriate container environment. Note: Does NOT update GitHub check status.For guidance on mapping tests to stage names, see
docs/source/reference/ci-overview.mdand the
scripts/test_to_stage_mapping.pyhelper.kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.
Summary by CodeRabbit