Skip to content

[None][chore] Fix slurm job name#11265

Merged
yingguo-trt merged 6 commits intoNVIDIA:release/1.2from
yingguo-trt:fix/slurm-job-name-config
Feb 5, 2026
Merged

[None][chore] Fix slurm job name#11265
yingguo-trt merged 6 commits intoNVIDIA:release/1.2from
yingguo-trt:fix/slurm-job-name-config

Conversation

@yingguo-trt
Copy link
Collaborator

@yingguo-trt yingguo-trt commented Feb 4, 2026

Summary by CodeRabbit

  • Tests

    • Enhanced GPU resource configurations with improved SLURM job naming logic for better resource allocation tracking.
  • Style

    • Minor formatting adjustment for code consistency.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This PR modifies performance testing utility configurations by adding GPU-specific job name prefix mappings to resource definitions and refactoring the SLURM job naming logic to derive names from GPU-type-based configurations. A minor formatting change is also applied to the executor module.

Changes

Cohort / File(s) Summary
GPU Resource Configuration
tests/integration/defs/perf/disagg/utils/common.py
Added job_name_prefix field to GPU configuration entries (GB200, GB200_LYRIS, GB300, H100, B200, B300); refactored get_slurm_job_name() to derive SLURM job names from GPU_TYPE via EnvManager using GPU-specific prefixes combined with SLURM_JOB_BASE_NAME; enhanced inline documentation for get_slurm_job_name(), get_slurm_set_segment(), and get_slurm_extra_args().
Code Formatting
tests/integration/defs/perf/disagg/execution/executor.py
Added blank line after log statement in submit_test_job().

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete, containing only the template structure without filled-in details in the Description and Test Coverage sections required by the template. Complete the Description section explaining what the SLURM job name fix addresses and why, and add Test Coverage section listing relevant tests that safeguard the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Fix slurm job name' is clearly related to the main changes in the PR, which involve fixing and enhancing SLURM job name configuration logic in the common.py file.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yingguo-trt
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34716 [ run ] triggered by Bot. Commit: f7e8e25

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34716 [ run ] completed with state SUCCESS. Commit: f7e8e25
/LLM/release-1.2/L0_MergeRequest_PR pipeline #310 (Partly Tested) completed with status: 'SUCCESS'

@yingguo-trt
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34868 [ reuse-pipeline ] triggered by Bot. Commit: f7e8e25

@yingguo-trt yingguo-trt enabled auto-merge (squash) February 5, 2026 02:04
Copy link
Collaborator

@fredricz-20070104 fredricz-20070104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
Fix the job name warning.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34868 [ reuse-pipeline ] completed with state SUCCESS. Commit: f7e8e25
Reusing PR_Github #34716 (Partly Tested) for commit f7e8e25

@yingguo-trt yingguo-trt disabled auto-merge February 5, 2026 02:56
@yingguo-trt yingguo-trt force-pushed the fix/slurm-job-name-config branch from f7e8e25 to a22a680 Compare February 5, 2026 03:09
@yingguo-trt yingguo-trt requested a review from xinhe-nv February 5, 2026 03:19
@yingguo-trt
Copy link
Collaborator Author

/bot run --skip-test

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34899 [ run ] triggered by Bot. Commit: d8fd8e2

Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
Signed-off-by: yingguo-trt <244492186+yingguo-trt@users.noreply.github.com>
@xinhe-nv xinhe-nv force-pushed the fix/slurm-job-name-config branch from d8fd8e2 to 1571d82 Compare February 5, 2026 04:39
@yingguo-trt yingguo-trt enabled auto-merge (squash) February 5, 2026 04:40
@tensorrt-cicd
Copy link
Collaborator

PR_Github #34899 [ run ] completed with state SUCCESS. Commit: d8fd8e2
/LLM/release-1.2/L0_MergeRequest_PR pipeline #331 (Partly Tested) completed with status: 'SUCCESS'

@yingguo-trt
Copy link
Collaborator Author

/bot reuse-pipeline

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34909 [ reuse-pipeline ] triggered by Bot. Commit: 1571d82

@tensorrt-cicd
Copy link
Collaborator

PR_Github #34909 [ reuse-pipeline ] completed with state SUCCESS. Commit: 1571d82
Reusing PR_Github #34899 (Partly Tested) for commit 1571d82

@yingguo-trt yingguo-trt merged commit 7f4a4cd into NVIDIA:release/1.2 Feb 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants