Skip to content

fix(ci): pass wheel filenames as job output instead of re-downloading #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pimlock merged 1 commit into from
Mar 18, 2026
Merged

fix(ci): pass wheel filenames as job output instead of re-downloading #418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/release-dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
timeout-minutes: 120
outputs:
wheel_version: ${{ needs.compute-versions.outputs.python_version }}
wheel_filenames: ${{ steps.filenames.outputs.wheel_filenames }}
container:
image: ghcr.io/nvidia/openshell/ci:latest
credentials:
Expand Down Expand Up @@ -132,6 +133,13 @@ jobs:
OPENSHELL_CARGO_VERSION="${{ needs.compute-versions.outputs.cargo_version }}" mise run python:build:macos
ls -la target/wheels/*.whl

- name: Capture wheel filenames
id: filenames
run: |
set -euo pipefail
WHEEL_FILENAMES=$(ls target/wheels/*.whl | xargs -n1 basename | paste -sd, -)
echo "wheel_filenames=${WHEEL_FILENAMES}" >> "$GITHUB_OUTPUT"

- name: Upload wheel artifacts
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -428,31 +436,23 @@ jobs:

trigger-wheel-publish:
name: Trigger Wheel Publish
needs: [compute-versions, release-devel]
needs: [compute-versions, build-python-wheels, release-devel]
runs-on: [self-hosted, nv]
timeout-minutes: 10
steps:
- name: Download wheel artifacts
uses: actions/download-artifact@v4
with:
name: python-wheels
path: release/

- name: Trigger GitLab CI
env:
GITLAB_CI_TRIGGER_TOKEN: ${{ secrets.GITLAB_CI_TRIGGER_TOKEN }}
GITLAB_CI_TRIGGER_URL: ${{ secrets.GITLAB_CI_TRIGGER_URL }}
RELEASE_VERSION: ${{ needs.compute-versions.outputs.python_version }}
WHEEL_FILENAMES: ${{ needs.build-python-wheels.outputs.wheel_filenames }}
run: |
set -euo pipefail
shopt -s nullglob
wheel_files=(release/*.whl)
if (( ${#wheel_files[@]} == 0 )); then
echo "No wheel artifacts found in release/" >&2
if [ -z "${WHEEL_FILENAMES}" ]; then
echo "No wheel filenames provided by build job" >&2
exit 1
fi

WHEEL_FILENAMES=$(printf '%s\n' "${wheel_files[@]##*/}" | paste -sd, -)
response=$(curl -X POST \
--fail \
--silent \
Expand Down
24 changes: 12 additions & 12 deletions .github/workflows/release-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ jobs:
timeout-minutes: 120
outputs:
wheel_version: ${{ needs.compute-versions.outputs.python_version }}
wheel_filenames: ${{ steps.filenames.outputs.wheel_filenames }}
container:
image: ghcr.io/nvidia/openshell/ci:latest
credentials:
Expand Down Expand Up @@ -153,6 +154,13 @@ jobs:
OPENSHELL_CARGO_VERSION="${{ needs.compute-versions.outputs.cargo_version }}" mise run python:build:macos
ls -la target/wheels/*.whl

- name: Capture wheel filenames
id: filenames
run: |
set -euo pipefail
WHEEL_FILENAMES=$(ls target/wheels/*.whl | xargs -n1 basename | paste -sd, -)
echo "wheel_filenames=${WHEEL_FILENAMES}" >> "$GITHUB_OUTPUT"

- name: Upload wheel artifacts
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -404,32 +412,24 @@ jobs:

trigger-wheel-publish:
name: Trigger Wheel Publish
needs: [compute-versions, release]
needs: [compute-versions, build-python-wheels, release]
runs-on: [self-hosted, nv]
timeout-minutes: 10
steps:
- name: Download wheel artifacts
uses: actions/download-artifact@v4
with:
name: python-wheels
path: release/

- name: Trigger GitLab CI
env:
GITLAB_CI_TRIGGER_TOKEN: ${{ secrets.GITLAB_CI_TRIGGER_TOKEN }}
GITLAB_CI_TRIGGER_URL: ${{ secrets.GITLAB_CI_TRIGGER_URL }}
RELEASE_VERSION: ${{ needs.compute-versions.outputs.python_version }}
RELEASE_TAG: ${{ env.RELEASE_TAG }}
WHEEL_FILENAMES: ${{ needs.build-python-wheels.outputs.wheel_filenames }}
run: |
set -euo pipefail
shopt -s nullglob
wheel_files=(release/*.whl)
if (( ${#wheel_files[@]} == 0 )); then
echo "No wheel artifacts found in release/" >&2
if [ -z "${WHEEL_FILENAMES}" ]; then
echo "No wheel filenames provided by build job" >&2
exit 1
fi

WHEEL_FILENAMES=$(printf '%s\n' "${wheel_files[@]##*/}" | paste -sd, -)
response=$(curl -X POST \
--fail \
--silent \
Expand Down
Loading