refactor(build): unify image build graph for cache reuse#390
Open
refactor(build): unify image build graph for cache reuse#390
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the two-image container build pipeline around one shared Docker build graph so gateway and cluster builds reuse the same Rust dependency cache instead of recompiling overlapping workspace state separately.
Related Issue
N/A
Changes
deploy/docker/Dockerfile.imagesbuild graphdocker-build-image.shhelper and route local, publish, and fast-deploy flows through itsupervisor-buildertarget so it reuses the same cache path as full image buildsTesting
mise run pre-commitpassesAdditional validation:
bash -n tasks/scripts/docker-build-image.sh tasks/scripts/docker-build-component.sh tasks/scripts/docker-build-cluster.sh tasks/scripts/docker-publish-multiarch.sh tasks/scripts/cluster-deploy-fast.sh tasks/scripts/cluster-bootstrap.sh tasks/scripts/cluster-push-component.shRUSTC_WRAPPER= cargo check --workspacedocker buildx build --check -f deploy/docker/Dockerfile.images --target gateway .docker buildx build --check -f deploy/docker/Dockerfile.images --target cluster .docker buildx build --check -f deploy/docker/Dockerfile.images --target supervisor-builder .mise run pre-commit(fails on existing workspace lint warnings outside this change)Checklist