Skip to content

fix(verification): send content type#382

Open
will-lms wants to merge 2 commits intoNVIDIA:mainfrom
will-lms:will/lms-validation-2
Open

fix(verification): send content type#382
will-lms wants to merge 2 commits intoNVIDIA:mainfrom
will-lms:will/lms-validation-2

Conversation

@will-lms
Copy link
Contributor

Summary

This PR modifies the inference provider verification request add a application/json content type.

Related Issue

Fixes #381

Changes

  • Send application/json content type on inference provider verification
  • Update chat completions and messages tests to assert the content type is received.

Testing

  • [Y] mise run pre-commit passes
    • Note I am seeing drop_privileges_succeeds_for_current_user fail both on main and on my branch. Seems unrealted.
  • [Y] Unit tests added/updated
  • [N] E2E tests added/updated (if applicable)

Checklist

  • [Y] Follows Conventional Commits
    • Follows for PR title.
  • [Y] Commits are signed off (DCO)
  • [N] Architecture docs updated (if applicable)

Signed-off-by: Will Burford <will@lmstudio.ai>
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

All contributors have signed the DCO ✍️ ✅
Posted by the DCO Assistant Lite bot.

@will-lms
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@johntmyers johntmyers requested a review from pimlock March 16, 2026 23:56
@will-lms
Copy link
Contributor Author

recheck

@pimlock
Copy link
Collaborator

pimlock commented Mar 17, 2026

@will-lms This looks great, thanks for your contribution!

We needed to update our CI config for checks to work on external contributions and it should be fixed on main now.

Could you please update your branch with the latest main and we can get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants