Skip to content

chore(ci): drop push-to-main trigger from shadow-docker-build#1019

Closed
jtoelke2 wants to merge 1 commit into
mainfrom
jtoelke/drop-shadow-push-trigger
Closed

chore(ci): drop push-to-main trigger from shadow-docker-build#1019
jtoelke2 wants to merge 1 commit into
mainfrom
jtoelke/drop-shadow-push-trigger

Conversation

@jtoelke2
Copy link
Copy Markdown
Collaborator

Summary

Per pimlock's review on #973: shadow workflows shouldn't auto-run on main pushes while we're still collecting Phase 3 data, so non-blocking failures don't clutter the CI run history. Switching shadow-docker-build.yml to workflow_dispatch only — same change applied to shadow-rust-native-build.yml directly on #973.

We keep manual dispatch for measurement runs. The auto-baseline-on-merge pattern was redundant once we had a stable cluster (7 green Phase 3 runs already in OS-127, range 6m32s–7m6s).

Related Issue

  • OS-127 — Phase 3
  • Companion change to #973 which applies the same change to shadow-rust-native-build.yml.

Changes

  • .github/workflows/shadow-docker-build.yml: drop push: branches: [main]; keep workflow_dispatch.

Testing

  • 4-line YAML edit; no behavior change for workflow_dispatch runs.
  • After merge, the workflow will only run on manual dispatch — verified via the same convention used by shadow-shared-cpu-spike.yml (Phase 2).

Checklist

  • Conventional commit format, signed-off.
  • No changes to existing actions or any other workflow.
  • Phase 3 data already meets exit criteria; future data collection via dispatch.

Per pimlock's review on #973: shadow workflows shouldn't auto-run on
main pushes while we're still collecting Phase 3 data, so failures don't
clutter the CI run history. Switch to `workflow_dispatch` only — we keep
manual dispatch for measurement runs and lose the auto-baseline-on-merge
(already had 7 green data points; the pattern was redundant).

Refs OS-127.

Signed-off-by: Jonas Toelke <jtoelke@nvidia.com>
@jtoelke2 jtoelke2 requested a review from a team as a code owner April 28, 2026 20:11
@drew
Copy link
Copy Markdown
Collaborator

drew commented May 12, 2026

@jtoelke2 is this PR still relevant?

@jtoelke2
Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #1273. This PR only removed the push trigger from .github/workflows/shadow-docker-build.yml; #1273 removed the obsolete shadow workflows entirely. Current main no longer has shadow-docker-build.yml, so this PR is no longer relevant.

@jtoelke2 jtoelke2 closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants